feat: [#206] add provider enum and config types#209
Merged
Conversation
Add extensible provider infrastructure for multi-provider deployment support. Domain Layer (src/domain/provider/): - Provider enum with Lxd and Hetzner variants - ProviderConfig enum for provider-specific configurations - LxdConfig with validated ProfileName - HetznerConfig with api_token, server_type, location fields Application Layer (src/application/.../provider/): - ProviderSection enum for JSON deserialization (tagged by "provider" field) - LxdProviderSection with raw String for JSON parsing - HetznerProviderSection with raw String fields - to_provider_config() method for validation and domain conversion Key Design Decisions: - Modular structure with separate files per provider for extensibility - DDD layer separation: raw primitives (application) vs validated types (domain) - Serde tagged enums for clean JSON format - Comprehensive test coverage following it_should_ naming convention
Member
Author
|
ACK 775fbeb |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add extensible provider infrastructure for multi-provider deployment support.
Closes #206
Changes
Domain Layer (
src/domain/provider/)Providerenum withLxdandHetznervariantsProviderConfigenum for provider-specific configurationsLxdConfigwith validatedProfileNameHetznerConfigwithapi_token,server_type,locationfieldsApplication Layer (
src/application/.../provider/)ProviderSectionenum for JSON deserialization (tagged by"provider"field)LxdProviderSectionwith rawStringfor JSON parsingHetznerProviderSectionwith rawStringfieldsto_provider_config()method for validation and domain conversionKey Design Decisions
"provider"field for discriminationit_should_naming conventionTesting