Implement trait-based message system for UserOutput extensibility#129
Merged
Conversation
- Define OutputMessage trait with format(), required_verbosity(), and channel() methods - Define Channel enum for routing messages to stdout/stderr - Implement concrete message types: ProgressMessage, SuccessMessage, WarningMessage, ErrorMessage, ResultMessage, StepsMessage - Add generic write() method to UserOutput for trait-based dispatch - Refactor all convenience methods to use trait dispatch - Add comprehensive tests including custom message type examples - All 1107 tests passing with 100% backward compatibility Co-authored-by: josecelano <58816+josecelano@users.noreply.github.com>
Co-authored-by: josecelano <58816+josecelano@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Implement trait-based message system for UserOutput module
Implement trait-based message system for UserOutput extensibility
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors
UserOutputto use trait dispatch instead of direct formatting, enabling new message types without modifying core code (Open/Closed Principle).Changes
Core abstractions
OutputMessagetrait withformat(),required_verbosity(),channel()methodsChannelenum (Stdout/Stderr) for routing logicwrite(&mut self, message: &dyn OutputMessage)method inUserOutputMessage implementations
ProgressMessage,SuccessMessage,WarningMessage,ErrorMessage,ResultMessage,StepsMessageprogress(),success(), etc.) now delegate towrite()Backward compatibility
Example: Adding custom message types
External code can now define application-specific message types without touching
UserOutput.Testing
15 new tests including custom message type demonstrations. All 1107 tests pass.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.