You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Enhance the run command output to display service URLs immediately after services start, plus a hint about the show command for full details. This improves actionability by giving users immediate access to their services without requiring a separate command.
Goal: Add service URLs to run command completion message
Modify RunCommandController::complete_workflow()
Load environment info after services start
Render service URLs using shared views
Add DNS hint for TLS environments
Add tip about show command
Phase 3: Testing & Documentation
Goal: Ensure quality and document the changes
Add unit tests for new shared views
Add integration tests for run command output
Update E2E tests
Update user documentation
Time Estimate: 4-6 hours
Acceptance Criteria
Note for Contributors: These criteria define what the PR reviewer will check. Use this as your pre-review checklist before submitting the PR to minimize back-and-forth iterations.
Quality Checks:
Pre-commit checks pass: ./scripts/pre-commit.sh
Task-Specific Criteria:
Output Requirements:
Run command displays service URLs after success message
Output includes all publicly accessible services
Health Check URL included only if publicly exposed (not localhost)
Prometheus not shown (internal only)
TLS environments show DNS configuration note
Tip about show command always displayed
Code Quality:
Shared view module created in src/presentation/views/commands/shared/service_urls/
URL rendering logic extracted and reused from show command
No duplication between run and show command views
Uses UserOutput methods (no println! or eprintln!)
Output goes to stdout via ProgressReporter::result()
Overview
Enhance the
runcommand output to display service URLs immediately after services start, plus a hint about theshowcommand for full details. This improves actionability by giving users immediate access to their services without requiring a separate command.Specification
See detailed specification: docs/issues/334-improve-run-command-output-with-service-urls.md
🏗️ Architecture Requirements
DDD Layer: Presentation
Module Path:
src/presentation/controllers/run/andsrc/presentation/views/commands/shared/Pattern: View composition with shared service URL views
Module Structure Requirements
src/presentation/views/commands/shared/service_urls/showcommand viewsrunandshowcommandsArchitectural Constraints
showcommandAnti-Patterns to Avoid
println!oreprintln!instead ofUserOutputImplementation Plan
Phase 1: Extract Shared View Components
Goal: Create reusable view components for service URL rendering
src/presentation/views/commands/shared/directorysrc/presentation/views/commands/shared/service_urls/moduleshowcommand to use shared viewsPhase 2: Enhance Run Command Output
Goal: Add service URLs to run command completion message
RunCommandController::complete_workflow()showcommandPhase 3: Testing & Documentation
Goal: Ensure quality and document the changes
Time Estimate: 4-6 hours
Acceptance Criteria
Quality Checks:
./scripts/pre-commit.shTask-Specific Criteria:
Output Requirements:
showcommand always displayedCode Quality:
src/presentation/views/commands/shared/service_urls/showcommandrunandshowcommand viewsUserOutputmethods (noprintln!oreprintln!)ProgressReporter::result()Testing:
Documentation:
Related