Update CampaignCategory.php#8
Merged
Merged
Conversation
Removed array typecast on getCategories. If a category has no sub categories we where getting errors like this: Symfony\Component\Debug\Exception\FatalThrowableError: Return value of Hypeit\TradeTracker\Model\CampaignCategory::getCategories() must be of the type array, null returned
Make response getCategories backwards compatible
stixx
requested changes
Oct 4, 2019
Comment on lines
+65
to
+67
| public function getCategories() | ||
| { | ||
| return $this->categories; | ||
| return $this->categories ?? []; |
Owner
There was a problem hiding this comment.
You can leave the return type restriction here if you force to always return an array. We can also set the default array type in the private property:
$this->categories = [];
Contributor
Author
There was a problem hiding this comment.
Yes that is true, I will change it.
return type restriction on getCategories
stixx
approved these changes
Oct 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed array typecast on getCategories. If a category has no sub categories we where getting errors like this:
Symfony\Component\Debug\Exception\FatalThrowableError: Return value of Hypeit\TradeTracker\Model\CampaignCategory::getCategories() must be of the type array, null returned