Add Ajax by tboulogne · Pull Request #17 · sonus21/error-tracker

tboulogne · 2020-10-22T13:27:34Z

Hello,

I'm back with a new contribution :-) :

Add ajax to list and navigation
Add columns filters :).

Regards

notification_send > for notification ticket_raise > for ticket creation

Check if a ticket already raised or notification send before sending

- add head_script block for extending script and css - add header_block - refactor detail template - refactor list template - ad pre tag to prettify request_data and exception detail view

add method to parse cookie

set APP_ERROR_XXX_ONCE to False

rename cookie_parse to parse_headers

…o sonus21-master

sync

- add filters - start translation sinto templates

sonus21

Please add test cases as well.

sonus21 · 2020-10-22T13:48:04Z

 class Migration(migrations.Migration):

    dependencies = [
-        ('error_tracker', '0001_initial'),


this is not correct, can you please verify if this is working? For me it's failing.

i open an issue on it : #16.
Not working for me too...

How are you adding error_tracker in the INSTALLED_APPS list?

yes...
But with django as name in django_migrations on a previous setup... :-).
I cleanup all, and rerun... no more result...

Note : i need to place error_tracker.django to INSTALLED_APPS to get error_tracker working... and not the documentation specs...

Can you please use error_tracker.DjangoErrorTracker in the installed app and verify?

I think in new way of declaring modules in django, this line should be présent into init.py of the module

default_app_config = 'error_tracker.apps.DjangoErrorTracker'

I wrote all my modules like this.

Can you please share python and Django version, this error is very strange.

local env (mac OS) :
python : 3.8.5
Django : 3.1.1

Unfortunately this is working fine for me on My Mac and same Django/Python version.
Can you please take master pull and install it via python setup.py install and see if you're still getting similar error?

i will git it a try

tboulogne · 2020-10-22T14:13:17Z

Please add test cases as well.

What test do you expect exactly ? I'm not a pro on test unit... :-)

sonus21 · 2020-10-22T14:17:16Z

Please add test cases as well.

What test do you expect exactly ? I'm not a pro on test unit... :-)

I expect at-least integration tests, see your last merge is failing. Merging and releasing such code is dangerous..

Please validate if your pull requests are at least passing existing tests.
https://travis-ci.org/github/sonus21/error-tracker/pull_requests

tboulogne · 2020-10-22T14:23:32Z

not only mine :-)

Strange : the failed are commits from my first pull request... not this one.

sonus21 · 2020-10-22T14:25:55Z

not only mine :-)

Strange : the failed are commits from my first pull request... not this one.

Oh! Flask optional commit has failed due to the fetch failure., https://travis-ci.org/github/sonus21/error-tracker/builds/732745931

I'm working on to get all test cases pass.

tboulogne · 2020-10-22T16:50:23Z

@sonus21 regarding the pull request how could us manage this ? Cancel it and redo it ?

tboulogne · 2020-10-22T19:25:44Z

@sonus21 for your eyes ;-)

sonus21 · 2020-10-23T00:21:22Z

    @classmethod
-    def get_exceptions_per_page(cls, page_number=1):
-        records = cls.objects.all().order_by('last_seen')
+    def get_exceptions_per_page(cls, query):


Hello,

This is not a kwargs but a true dict i will reuse as filter:

if not query: records = cls.objects.all().order_by('last_seen') else: records = cls.objects.filter(**query).order_by('last_seen')

I will submit a commit with a fix on the jquery in the template. Url parameter are not well formatted when multiple parameter, so this dict, is not well formatted too.

This method is different from super class(ModelMixin), if someone has implemented via keyword argument page_number. It'll start throwing errors.

That's the reason I'm suggesting this method to take kwargs as parameter. We should not break backward compatibility.

Ok let me see how i could manage this...

sonus21 · 2020-10-23T05:19:22Z

 import re
 import json
 from django.http import RawPostDataException
+from http.cookies import SimpleCookie


oh ! yes. A bad copy/paste duplicate this on line 200. On next commit will be fix.

just submit a fix, let me know.

It seems http.cookies is not part of python 2.7 and it will fail there, that's the reason it's moved with try except

ok, i would prefer this on headers

try: from http.cookies import SimpleCookie except: pass

instead to see from http.cookies import SimpleCookie inside code.

ok for you ?

But your code would down the line, When you're trying to use SimpleCookie module, you need to add some flag to say this is not available.

fix duplicate SimpleCookie line optimize jquery script for ajax

sonus21 · 2020-10-23T05:36:32Z

+
    error = False
-    errors = model.get_exceptions_per_page(page_number=page)
+    errors = model.get_exceptions_per_page(**query)


We need to set page_number if it's missing. And please add **kwargs in ModelMixin, for compatibility.

Don't understand your meaning :
on page_number

def get_exceptions_per_page(cls, **query): if 'page' in query: page_number = query['page'] del query['page'] else: page_number = 1

And please add **kwargs in ModelMixin, for compatibility.

You mean replace in ModelMixin :

@classmethod @abc.abstractmethod def get_exceptions_per_page(cls, page_number=1):

with

@classmethod @abc.abstractmethod def get_exceptions_per_page(cls, **kwargs):

We need to update model mixin as

@classmethod @abc.abstractmethod def get_exceptions_per_page(cls, page_number=1, **kwargs):

Now when we send GET query parameter as dict than we should do something like this

model.get_exceptions_per_page(page_number=page, **query)

I know this will still break the compatibility, so we'll release 2.0.0 to make things fine.

ok,

i set in Mixin :

@classmethod @abc.abstractmethod def get_exceptions_per_page(cls, page_number=1, **kwargs): """ An object having these properties, has_next, next_num, has_prev, prev_num and items on the returned object like SQLAlchemy's Pagination :return: a paginated object """ raise NotImplementedError

In models.py

@classmethod def get_exceptions_per_page(cls, page_number=1, **query): if query and 'page' in query: page_number = query['page'] del query['page'] if not query: records = cls.objects.all().order_by('last_seen') else: records = cls.objects.filter(**query).order_by('last_seen')

Ok for you ?

yes this works for me, but do you any downside of using **query in filter? For example how it will handle the case of partial match.

step by step :-). We will start with a full search and study an easy way to make partial search later..
(this later could be there quickly :-) )

and the time is there :-):

Could be manage like this:

query = {"{}__contains".format(k): v for k, v in query.items()}

add page_number to get_exceptions_per_page add partial text filter

change contains to icontains on query

tboulogne · 2020-10-25T18:27:49Z

@sonus21 are we ok on this ?

sonus21 · 2020-10-26T01:41:03Z


    dependencies = [
-        ('error_tracker', '0001_initial'),
+        ('django', '0001_initial'),


do we still need this?

will need to add a mention for updating on README for makemigrations on existing installation.

sonus21 · 2020-10-26T01:42:59Z

            try:
-                from http.cookies import SimpleCookie
                try:
+                    from http.cookies import SimpleCookie


does not seem to be at correct place

in a previous conversation you talk about moving this... misunderstanding from my side. Now on headers.

It seems you need to see try/except statement.

try:
from http.cookies import SimpleCookie
// do something with SimpleCookie
except ImportError:
pass

Don't understand your meaning here. Could you explain more here to avoid another misunderstanding please before any change here ?

Sure, when you don't have http.cookies module then you can store cookie data as it as, otherwise we can try to parse cookie data using SimpleCookie module. You can compare this file data with the last commit made by me.

Move Simplecookie to head

sonus21 · 2020-10-26T09:59:46Z

@@ -1,23 +0,0 @@
-# Generated by Django 3.1.2 on 2020-10-18 11:11
-


We would need this file.

As you ask previously if we really need it... Will be restored on next commit.

We need this file but app name is not correct, we can connect over zoom/goole hangout to see what's not working you but same is working for me.

try/except SimpleCookie

sonus21 · 2020-10-26T12:45:17Z

Please fix test issues.

See https://travis-ci.org/github/sonus21/error-tracker/jobs/738936246

tboulogne · 2020-10-26T14:12:53Z

Please fix test issues.

See https://travis-ci.org/github/sonus21/error-tracker/jobs/738936246

Running pytest on my side, don't have same errors.

Note : on the CI, lots of errors from flask...

================================================================ ERRORS =================================================================
_______________________________________ ERROR collecting tests/DjangoTest/tests/test_end_point.py _______________________________________
ImportError while importing test module '/Users/XXX/Projets/TNG/error-tracker/tests/DjangoTest/tests/test_end_point.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
../../../.virtualenvs/meubleframe/lib/python3.8/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
../error-tracker/tests/DjangoTest/tests/test_end_point.py:13: in <module>
    from util import TestBase
E   ModuleNotFoundError: No module named 'util'
=========================================================== warnings summary ============================================================
../../../.virtualenvs/meubleframe/lib/python3.8/distutils/__init__.py:4
  /Users/XXXX/.virtualenvs/meubleframe/lib/python3.8/distutils/__init__.py:4: DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses
    import imp

-- Docs: https://docs.pytest.org/en/stable/warnings.html
======================================================== short test summary info ========================================================
ERROR ../error-tracker/tests/DjangoTest/tests/test_end_point.py
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
====================================================== 1 warning, 1 error in 0.90s ======================================================

sonus21 · 2020-10-26T14:29:42Z

Please fix test issues.
See https://travis-ci.org/github/sonus21/error-tracker/jobs/738936246

Running pytest on my side, don't have same errors.

Note : on the CI, lots of errors from flask...

================================================================ ERRORS =================================================================
_______________________________________ ERROR collecting tests/DjangoTest/tests/test_end_point.py _______________________________________
ImportError while importing test module '/Users/XXX/Projets/TNG/error-tracker/tests/DjangoTest/tests/test_end_point.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
../../../.virtualenvs/meubleframe/lib/python3.8/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
../error-tracker/tests/DjangoTest/tests/test_end_point.py:13: in <module>
    from util import TestBase
E   ModuleNotFoundError: No module named 'util'
=========================================================== warnings summary ============================================================
../../../.virtualenvs/meubleframe/lib/python3.8/distutils/__init__.py:4
  /Users/XXXX/.virtualenvs/meubleframe/lib/python3.8/distutils/__init__.py:4: DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses
    import imp

-- Docs: https://docs.pytest.org/en/stable/warnings.html
======================================================== short test summary info ========================================================
ERROR ../error-tracker/tests/DjangoTest/tests/test_end_point.py
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
====================================================== 1 warning, 1 error in 0.90s ======================================================

You should run bash run-tests.sh, this command will report test failures. You can also find via run-tests.sh how does test suite work in error-tracker. It's not using pytests, it's built on basic python test modules.

tboulogne · 2020-10-26T17:15:05Z

@sonus21 fix test. No errors on django part on my side. But my fix seems to conflict. Don't know how to solve this.

tboulogne added 19 commits October 18, 2020 08:53

Add field to prevent multiple notifications

4e7bd19

notification_send > for notification ticket_raise > for ticket creation

Check previous send

c58bf62

Check if a ticket already raised or notification send before sending

fix type

225c4ea

update fields

14a376a

save notification send confirm

f943cc2

add returnt obj to create_or_update_entity

f746ec6

add login_required to permission wrapper

ce18743

Pretiffy request_data display

51bf232

- upgrade to bootstrap 4

ace6530

- add head_script block for extending script and css - add header_block - refactor detail template - refactor list template - ad pre tag to prettify request_data and exception detail view

remove border

f8d5f23

add APP_ERROR_NOTIFICATION_ONCE and APP_ERROR_TICKET_ONCE

eaadf4c

fix migrations

4321131

Set default to NONE

5d10afd

add method to parse cookie

change notification_send to notification_sent

50a9bb7

set APP_ERROR_XXX_ONCE to False

linting in model

0d12fe8

rename cookie_parse to parse_headers

Merge branch 'master' of https://github.com/sonus21/error-tracker int…

68aafcd

…o sonus21-master

Merge branch 'sonus21-master'

6c68807

sync

add ajax list

e78538b

- add ajax to list

ec4608d

- add filters - start translation sinto templates

sonus21 reviewed Oct 22, 2020

View reviewed changes

sonus21 reviewed Oct 23, 2020

View reviewed changes

query refactoring for get_exceptions_per_page

6cbc853

sonus21 reviewed Oct 23, 2020

View reviewed changes

simplify query and change query to **query

f8da4ec

fix duplicate SimpleCookie line optimize jquery script for ajax

sonus21 reviewed Oct 23, 2020

View reviewed changes

tboulogne added 3 commits October 23, 2020 11:35

Move SimpleCookie into code

ea8dd3e

fix mixin with kwarks

6b946ab

add page_number to get_exceptions_per_page add partial text filter

filter input on keypress

61d28a8

change contains to icontains on query

sonus21 requested changes Oct 26, 2020

View reviewed changes

remove 002_xx migrations

9ca2c49

Move Simplecookie to head

sonus21 reviewed Oct 26, 2020

View reviewed changes

restore migration file

ebe836e

try/except SimpleCookie

tboulogne added 3 commits October 26, 2020 17:20

fix test

ad7abcf

ccheck

e2d04a2

remove login_required

0b6ae77

tboulogne and others added 2 commits October 26, 2020 18:19

complete translation string

04dc8fa

Merge branch 'master' into master

209a0c1

sonus21 merged commit 4c8193c into sonus21:master Oct 27, 2020

		@@ -1,23 +0,0 @@
		# Generated by Django 3.1.2 on 2020-10-18 11:11

Uh oh!

Conversation

tboulogne commented Oct 22, 2020

Uh oh!

sonus21 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tboulogne commented Oct 22, 2020

Uh oh!

sonus21 commented Oct 22, 2020

Uh oh!

tboulogne commented Oct 22, 2020

Uh oh!

sonus21 commented Oct 22, 2020

Uh oh!

tboulogne commented Oct 22, 2020

Uh oh!

tboulogne commented Oct 22, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonus21 Oct 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tboulogne Oct 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tboulogne commented Oct 25, 2020

Uh oh!

Choose a reason for hiding this comment

sonus21 Oct 23, 2020 •

edited

Loading

tboulogne Oct 23, 2020 •

edited

Loading

tboulogne commented Oct 26, 2020 •

edited

Loading