Skip to content

Configurable timeouts for emitter http requests - #259

Closed
Deyan Deyanov (DeyanDeyanov) wants to merge 1 commit into
snowplow:masterfrom
DeyanDeyanov:configurable_http_request_timeout
Closed

Configurable timeouts for emitter http requests#259
Deyan Deyanov (DeyanDeyanov) wants to merge 1 commit into
snowplow:masterfrom
DeyanDeyanov:configurable_http_request_timeout

Conversation

@DeyanDeyanov

Copy link
Copy Markdown
Contributor

The PR addresses this issue: #258

@snowplowcla

Copy link
Copy Markdown

Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://docs.snowplowanalytics.com/docs/contributing/contributor-license-agreement/ to learn more and sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

@DeyanDeyanov

Copy link
Copy Markdown
Contributor Author

I signed it

@paulboocock

Copy link
Copy Markdown
Contributor

Thanks for signing the CLA. Once I have more clarity on when we'll get the next python tracker update out, I'll give you an update.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution, Deyan Deyanov (@DeyanDeyanov)! I cherry-picked your commit to be published in the upcoming 0.10.0 release.

@matus-tomlein

Copy link
Copy Markdown
Contributor

Cherry-picked into the 0.10.0 release branch.

Colin Nattrass (cpnat) added a commit to kolonialno/snowplow-python-tracker that referenced this pull request Apr 5, 2022
* Fix pycontracts incompatibility with pyparsing v3 (closes snowplow#255)

* Update python versions in run-tests script (closes snowplow#256)

* Prepare for release

* Add Python 3.10 support (close snowplow#254)

PR snowplow#260

* Remove pycontracts library that wasn't compatible with Python 3.10
* Add Python type hints to all function arguments and return values
* Remove support for Python 2 due to the type hints
* Add custom contracts (e.g., non_empty_string) evaluated at the start of functions
* Run through Flake8 linter and correct style
* Remove Python 2 from Github action build
* Add Dockerfile for running tests under all supported Python versions

* Add configurable timeout for HTTP requests (close snowplow#258)

PR snowplow#259

* Prepare for release

* Increment version

Co-authored-by: adatzer <ada@snowplowanalytics.com>
Co-authored-by: Matúš Tomlein <matus.tomlein@gmail.com>
Co-authored-by: Deyan Deyanov <deyan@insurify.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants