Skip to content

Allow non ascii characters to be encoded using Base64#219

Closed
Jack Williamson (jackwilliamson) wants to merge 1 commit into
snowplow:masterfrom
jackwilliamson:master
Closed

Allow non ascii characters to be encoded using Base64#219
Jack Williamson (jackwilliamson) wants to merge 1 commit into
snowplow:masterfrom
jackwilliamson:master

Conversation

@jackwilliamson

Copy link
Copy Markdown

Solves UnicodeEncodeError which occurs whenever a string that is added to the payload's json contains non-ascii characters.

Fixes #194

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.2%) to 80.253% when pulling b4ee519 on jackwilliamson:master into 4550310 on snowplow:master.

@snowplowcla

Copy link
Copy Markdown

Confirmed! Jack Williamson (@jackwilliamson) has signed the Individual Contributor License Agreement. Thanks so much

@jethron

Copy link
Copy Markdown

The alternate fix is to revert fd2412a which introduced the incorrect behaviour from what was the correct JSON escaping to begin with. See #123

Either option is cleaner than #188 even though it includes tests.

This has been dropping events and throwing exceptions in production applications for quite a while and should probably have been a higher priority and fixed a lot sooner...

@oguzhanunlu

Copy link
Copy Markdown
Member

Thanks for the contribution Jack Williamson (@jackwilliamson) ! It is cherry-picked to the release branch at #224 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow non ascii characters to be encoded using Base64

5 participants