Allow non ascii characters to be encoded using Base64#219
Closed
Jack Williamson (jackwilliamson) wants to merge 1 commit into
Closed
Allow non ascii characters to be encoded using Base64#219Jack Williamson (jackwilliamson) wants to merge 1 commit into
Jack Williamson (jackwilliamson) wants to merge 1 commit into
Conversation
|
Confirmed! Jack Williamson (@jackwilliamson) has signed the Individual Contributor License Agreement. Thanks so much |
|
The alternate fix is to revert fd2412a which introduced the incorrect behaviour from what was the correct JSON escaping to begin with. See #123 Either option is cleaner than #188 even though it includes tests. This has been dropping events and throwing exceptions in production applications for quite a while and should probably have been a higher priority and fixed a lot sooner... |
Member
|
Thanks for the contribution Jack Williamson (@jackwilliamson) ! It is cherry-picked to the release branch at #224 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves UnicodeEncodeError which occurs whenever a string that is added to the payload's json contains non-ascii characters.
Fixes #194