Release 0.8.2#209
Merged
Merged
Conversation
Michael Hadam (mhadam)
requested review from
Alexander Dean (alexanderdean) and
Anton Parkhomenko (chuwy)
This was referenced Oct 1, 2018
Member
|
Removing myself as reviewer - Anton Parkhomenko (@chuwy) are you okay to take a look, or reassign if you would prefer someone else to review. |
Anton Parkhomenko (chuwy)
left a comment
Anton Parkhomenko (chuwy)
left a comment
Contributor
There was a problem hiding this comment.
Looks good overall, but it would be nice to have small story behind #207 (in the ticket preferably).
Michael Hadam (mhadam)
force-pushed
the
develop
branch
from
93e43aa to
3add8e3
Compare
Anton Parkhomenko (chuwy)
approved these changes
Oct 22, 2018
Michael Hadam (mhadam)
force-pushed
the
develop
branch
3 times, most recently
from
dd44862 to
f3f5a74
Compare
|
Guys, doesn't it make sense for this to go into this release as well? #188 |
Member
|
Michael Hadam (@mhadam) Anton Parkhomenko (@chuwy) - what do you think? |
Michael Hadam (mhadam)
force-pushed
the
develop
branch
from
f3f5a74 to
5f01606
Compare
Michael Hadam (mhadam)
force-pushed
the
develop
branch
3 times, most recently
from
a26fc22 to
aa49eee
Compare
Michael Hadam (mhadam)
force-pushed
the
develop
branch
from
aa49eee to
afc1c02
Compare
Michael Hadam (mhadam)
force-pushed
the
develop
branch
3 times, most recently
from
d69a6bb to
51ef254
Compare
| @@ -1,4 +1,14 @@ | |||
| Version 0.8.0 (2016-09-xx) | |||
| Version 0.8.2 (2018-12-01) | |||
|
|
||
| __version_info__ = (0, 8, 0) | ||
| __version__ = ".".join(str(x) for x in __version_info__) | ||
| __version_info__ = (0, 8, 2) |
Michael Hadam (mhadam)
force-pushed
the
develop
branch
from
51ef254 to
2aba5ba
Compare
|
The problem related and solved in #188 was already solved and merged in another PR? If not, what is the reason to don't merge it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.