Initializes Celery app in CeleryEmitter.#196
Initializes Celery app in CeleryEmitter.#196Julio Carlos Menendez (juliomenendez) wants to merge 1 commit into
Conversation
|
Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://github.com/snowplow/snowplow/wiki/CLA to learn more and sign. Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks. |
|
I signed it! |
Ben Fradet (BenFradet)
left a comment
There was a problem hiding this comment.
LGTM, I'll let Anton Parkhomenko (@chuwy) have a second look
Anton Parkhomenko (chuwy)
left a comment
There was a problem hiding this comment.
Thank you so much Julio Carlos Menendez (@juliomenendez). That totally makes sense. I'd actually go further and make emiiters a package with separate celery_emitter module to not confuse people who don't use celery, but this is also a good solution for now.
|
Thanks! What should I do about the tests failing for Python 3.3? Remove that version entirely maybe? |
|
Good question. For me Python 3.3 doesn't look outdated yet. Let's wait until we have a bandwidth for a new release and we'll decide what to do with 3.3 then. Also, it looks like problem not in tracker, but in other our project - release-manager, which is a bit suspicious. Maybe we can stick with earlier version (e.g. 0.2.0) |
|
Confirmed! Julio Carlos Menendez (@juliomenendez) has signed the Individual Contributor License Agreement. Thanks so much |
|
Hi Julio Carlos Menendez (@juliomenendez) , thanks for the contribution! It is cherry-picked to the release branch at #224 . |
Fixes #185