python3 compatibility - #193
Closed
Jon Kaczynski (jon-ga) wants to merge 1 commit into
Closed
Conversation
While the package is being tested against python 3.3, 3.4, and 3.5
upstream, it seems that the hard dependency on "gevent==1.0.2"
results in an install failure under Python 3.5.1.
Traceback (most recent call last):
...
File "/private/var/folders/r_/y0nsq9k54tn0rpgh62m6t4_40000gn/T/pip-build-pi5tyo08/gevent/setup.py", line 111, in make_universal_header
print >>f, line
TypeError: unsupported operand type(s) for >>: 'builtin_function_or_method' and '_io.TextIOWrapper'
Upgrading to a 1.1.x release of gevent, which appears to include
python3 support.
- http://www.gevent.org/whatsnew_1_0.html
- http://www.gevent.org/whatsnew_1_1.html
|
Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://github.com/snowplow/snowplow/wiki/CLA to learn more and sign. Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks. |
Ben Fradet (BenFradet)
approved these changes
Jul 13, 2017
Ben Fradet (BenFradet)
left a comment
Ben Fradet (BenFradet)
left a comment
There was a problem hiding this comment.
LGTM, please sign the CLA so this can be merged
Member
|
No CLA, closing in favor of #200 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While the package is being tested against python 3.3, 3.4, and 3.5
upstream, it seems that the hard dependency on "gevent==1.0.2"
results in an install failure under Python 3.5.1.
Upgrading to a 1.1.x release of gevent, which appears to include
python3 support.