Skip to content

Allow empty strings in string_or_none contract#189

Closed
Joshua Blum (joshblum) wants to merge 1 commit into
snowplow:masterfrom
joshblum:allow-empty-strings
Closed

Allow empty strings in string_or_none contract#189
Joshua Blum (joshblum) wants to merge 1 commit into
snowplow:masterfrom
joshblum:allow-empty-strings

Conversation

@joshblum

Copy link
Copy Markdown
Contributor

Addresses #184

@coveralls

Coveralls (coveralls) commented Feb 7, 2017

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 80.738% when pulling 9b57b84 on joshblum:allow-empty-strings into 91da00a on snowplow:master.

@snowplowcla

Copy link
Copy Markdown

Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://github.com/snowplow/snowplow/wiki/CLA to learn more and sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

@joshblum

Copy link
Copy Markdown
Contributor Author

Signed :)

@snowplowcla

Copy link
Copy Markdown

Confirmed! Joshua Blum (@joshblum) has signed the Individual Contributor License Agreement. Thanks so much

@joshblum

Copy link
Copy Markdown
Contributor Author

Anton Parkhomenko (@chuwy) How does this look to address #184 ??

@joshblum

Copy link
Copy Markdown
Contributor Author

Anton Parkhomenko (@chuwy) any update?

@chuwy

Copy link
Copy Markdown
Contributor

Hey Joshua Blum (@joshblum)! Sure, this looks fine. I milestoned corresponding issue with closest release, it'll be included.

@joshblum

Copy link
Copy Markdown
Contributor Author

Awesome thanks :)

@oguzhanunlu

Copy link
Copy Markdown
Member

Thanks for the contribution Joshua Blum (@joshblum) ! It is cherry-picked to the release branch at #224 .

@joshblum Joshua Blum (joshblum) deleted the allow-empty-strings branch June 27, 2019 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants