Skip to content

Update on_success docstring #358

@jnafzig

Description

Describe the bug

The on_success method is being passed the actual successful events:

self.on_success(success_events)

However, the docs here

Gets passed the number of events flushed.
say that this function will be passed the "number of events flushed"

The docs here are similarly incorrect:
https://docs.snowplow.io/docs/collecting-data/collecting-from-own-applications/python-tracker/emitters/#on_success

To Reproduce
The example in the online docs under on_failure reproduce the problem: https://docs.snowplow.io/docs/collecting-data/collecting-from-own-applications/python-tracker/emitters/#on_failure

Expected behavior
The docs should match the behavior.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions