Update so a transaction and its items have the same txnid and dtm

[alexanderdean]

With currently structure, these would be different getween the transaction and each transaction item. Is that okay? Probably needs changing.

But lower priority.

[alexanderdean]

Leaving open for future releases

[alexanderdean]

Asking Yali (@yalisassoon) if he sees any issues with this. Note that txnid is the internal Snowplow transaction ID, not the ecommerce transaction ID...

[alexanderdean]

Will be owned by Fred.

[yalisassoon]

No issues from my point of view

On Thu, Mar 20, 2014 at 11:49 AM, Alexander Dean
notifications@github.comwrote:

Will be owned by Fred.

Reply to this email directly or view it on GitHubhttps://github.com//issues/25#issuecomment-38157992
.

Co-founder
Snowplow Analytics http://snowplowanalytics.com/
The Roma Building, 32-38 Scrutton Street, London EC2A 4RQ, United Kingdom
+44 (0)203 589 6116
+44 7841 954 117
Yali (@yalisassoon) https://twitter.com/yalisassoonhttps://twitter.com/yalisassoon

[alexanderdean]

Okay, let's tackle in Version 1.0.0. Not high priority.

[fblundun]

Potential issue: if multiple users are being tracked at once, there isn't a way to know which transactions belong to the same user.

One solution is to have an optional argument for both track_ecommerce_transaction and track_ecommerce_transaction_item which is the name of the transaction. The tracker would maintain a dictionary of these names which would be used to keep each transaction and its items together. If the transaction name isn't provided there are two possibilities:

• Assume that all transaction events belong together and should have the same timestamp and id
• Assume that all transaction events are separate

The transaction name could by default be the user ID. This would prevent different users' transactions getting combined.

We could also rename track_ecommerce_transaction_item to add_item, track_ecommerce_transaction to add_transaction, and add a track_transaction method to commit the transaction like in the JS tracker.

[alexanderdean]

Totally agree we shouldn't try to maintain some kind of state between individual track_ecommerce_transaction and ..._transaction_item calls.

Couldn't we just merge into one method, which takes an array of transaction items as well as the transaction itself?

[fblundun]

That sounds like a better idea. Especially as they share several parameters.

[alexanderdean]

Nice one