Add initial localStorage support for intermittent offline beacons - #24
Closed
Ryan Sorensen (rcs) wants to merge 2 commits into
Closed
Add initial localStorage support for intermittent offline beacons#24Ryan Sorensen (rcs) wants to merge 2 commits into
Ryan Sorensen (rcs) wants to merge 2 commits into
Conversation
Contributor
Author
Member
|
Ryan Sorensen (@rcs) - whoah, this is awesome! Thanks for this. Two things:
|
…alStorage. Taken from modernizr
Contributor
Author
|
Grabbed the code out of Modernizr, since it's explicitly dealing with some private browsing features that wouldn't be hit otherwise. The CLA was submitted yesterday. |
Member
|
Thanks Ryan Sorensen (@rcs) - code and CLA looks great. Will merge this into a branch for a 0.13.0 release... Will need quite a lot of testing at our end to check it doesn't break anything... |
Fred Blundun (fblundun)
added a commit
that referenced
this pull request
Mar 3, 2014
Member
|
This has been pulled into master through the 1.0.0 work - big thanks Ryan Sorensen (@rcs) ! Closing. |
Member
|
My bad - this is going into 2.0.0, reopening till then... |
Fred Blundun (fblundun)
added a commit
that referenced
this pull request
Mar 27, 2014
Fred Blundun (fblundun)
added a commit
that referenced
this pull request
Apr 10, 2014
Fred Blundun (fblundun)
added a commit
that referenced
this pull request
May 14, 2014
…amespacing in localStorage (#24)
Fred Blundun (fblundun)
added a commit
that referenced
this pull request
Jun 30, 2014
Fred Blundun (fblundun)
added a commit
that referenced
this pull request
Jun 30, 2014
…amespacing in localStorage (#24)
Member
|
This is published now - huge thanks, Ryan Sorensen (@rcs), closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for queuing request into localStorage when they can't be loaded immediately.
The queue will try to fire all requests off to the collector whenever a request is requested and successful.
I haven't been able to test in a browser without localStorage support -- any tips there?