Update bundlemon to version 3 to fix CI failures on change check#1469
Update bundlemon to version 3 to fix CI failures on change check#1469Matus Tomlein (matus-tomlein) merged 4 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the PR change-check GitHub Action to use Bundlemon v3 in order to restore/maintain bundle size checks in CI.
Changes:
- Bump Bundlemon from
1.4.0to3. - Update Bundlemon environment variables (new project ID, add API key and GitHub token).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| - name: Check bundle size using bundlemon | ||
| run: npx bundlemon@1.4.0 | ||
| run: npx bundlemon@3 |
There was a problem hiding this comment.
Using npx bundlemon@3 leaves the workflow non-deterministic because it will pick up whatever the latest 3.x release is at runtime. To make CI reproducible and avoid unexpected breakages, pin to an exact version (or at least a minor/patch range you control).
| run: npx bundlemon@3 | |
| run: npx bundlemon@3.0.0 |
| BUNDLEMON_PROJECT_ID: 69e5e44cf67d5035af9fd1c0 | ||
| BUNDLEMON_PROJECT_APIKEY: ${{ secrets.BUNDLEMON_PROJECT_APIKEY }} | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| CI_COMMIT_SHA: ${{ github.event.pull_request.head.sha || github.sha }} |
There was a problem hiding this comment.
This job runs on the pull_request event, but secrets.BUNDLEMON_PROJECT_APIKEY is not provided to workflows triggered from forked PRs. If bundlemon requires the API key, this step will fail for external contributors. Consider guarding the step with an if: that checks the PR is from the same repo (or that the secret is non-empty), or switching to a safer alternative pattern for forks.
Matus Tomlein (matus-tomlein)
force-pushed
the
fix/bundlemon_ci
branch
from
2baff7c to
cbd4b75
Compare
# 50-character subject line # * Present tense # # 72-character wrapped longer description. This should answer: # * Why was this change necessary? # * How does it address the problem? # * Are there any side effects?
No description provided.