Round resolution in mobile context to avoid validation failures on Android - #1404
Merged
Matus Tomlein (matus-tomlein) merged 3 commits intoJan 8, 2025
Conversation
Matus Tomlein (matus-tomlein)
requested a review
from Miranda Wilson (mscwilson)
January 7, 2025 10:58
BundleMonUnchanged files (6)
No change in files bundle size Final result: ✅ View report in BundleMon website ➡️ |
Miranda Wilson (mscwilson)
approved these changes
Jan 7, 2025
Miranda Wilson (mscwilson)
left a comment
Miranda Wilson (mscwilson)
left a comment
There was a problem hiding this comment.
would be good to update the Android test too!
Matus Tomlein (matus-tomlein)
deleted the
issue/round_resolution_in_mobile_context
branch
January 8, 2025 15:09
Matus Tomlein (matus-tomlein)
added a commit
that referenced
this pull request
Jan 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug identified in snowplow-industry-solutions/snowplow-javascript-tracker-examples#60 where the mobile_context entity failed validation due to the resolution field being too long.
The change converts the width and height to integer by taking the floor of the values.