Add a platform context plugin to the React Native tracker to track device information - #1395
Merged
Matus Tomlein (matus-tomlein) merged 2 commits intoDec 10, 2024
Conversation
Matus Tomlein (matus-tomlein)
requested review from
Greg Leonard (greg-el) and
Miranda Wilson (mscwilson)
November 28, 2024 09:48
BundleMonFiles added (6)
Total files change +105.95KB 0% Final result: ✅ View report in BundleMon website ➡️ |
Matus Tomlein (matus-tomlein)
force-pushed
the
wip/react-native
branch
from
November 28, 2024 13:24
382f387 to
939388c
Compare
Matus Tomlein (matus-tomlein)
force-pushed
the
issue/react-native-platform-context
branch
from
November 28, 2024 13:42
3a6dd59 to
8700480
Compare
Miranda Wilson (mscwilson)
approved these changes
Nov 28, 2024
| /** | ||
| * Amount of memory in bytes available to the current app. | ||
| * The property is not tracked in the current version of the tracker due to the tracker not being able to access the API, see the issue here: https://github.com/snowplow/snowplow-ios-tracker/issues/772 | ||
| * Note: this property is not automatically assigned but can be assigned using the PlatformContextRetriever. |
There was a problem hiding this comment.
is it tracked if it's set with PlatformContextRetriever?
Contributor
Author
There was a problem hiding this comment.
Yes, that's true, when it's manually provided by the PlatformContextRetriever, then it should be added to the platform context.
…vice information # Conflicts: # api-docs/docs/react-native-tracker/markdown/react-native-tracker.reactnativetracker.md # api-docs/docs/react-native-tracker/react-native-tracker.api.md # trackers/react-native-tracker/src/constants.ts # trackers/react-native-tracker/src/tracker.ts # trackers/react-native-tracker/test/tracker.test.ts
Matus Tomlein (matus-tomlein)
force-pushed
the
issue/react-native-platform-context
branch
from
November 29, 2024 08:48
8700480 to
07180aa
Compare
Matus Tomlein (matus-tomlein)
deleted the
issue/react-native-platform-context
branch
December 10, 2024 08:08
Matus Tomlein (matus-tomlein)
added a commit
that referenced
this pull request
Dec 16, 2024
…vice information (#1395)
Merged
Matus Tomlein (matus-tomlein)
added a commit
that referenced
this pull request
Jan 13, 2025
…vice information (#1395)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the platform context to the React Native tracker that tracks information about the device.
The information available in React Native is quite limited, so only a few properties are auto-tracked: osType, osVersion, deviceManufacturer, deviceModel, resolution, language, scale
The rest can be provided by a
platformContextRetrieverconfiguration option. This is the same as on our mobile trackers.There is also an option to provide
platformContextPropertiesconfiguration option that filters which properties will be tracked. Also reflects our mobile trackers.