Skip to content

Fix postPath configuration being ignored (close #1376) - #1377

Merged
Matus Tomlein (matus-tomlein) merged 1 commit into
release/4.0.2from
issue/fix_post_path
Nov 11, 2024
Merged

Fix postPath configuration being ignored (close #1376)#1377
Matus Tomlein (matus-tomlein) merged 1 commit into
release/4.0.2from
issue/fix_post_path

Conversation

@matus-tomlein

Copy link
Copy Markdown
Contributor

Issue #1376

In the v4 release, a bug was introduced that the postPath configuration option was ignored by the tracker – despite it being configured, the tracker is still using the default tp2 path.

This PR fixes the issue and makes sure to use the configuration option.

@bundlemon

bundlemon Bot commented Nov 11, 2024

Copy link
Copy Markdown

BundleMon

Files added (6)
Status Path Size Limits
trackers/javascript-tracker/dist/sp.js
+24.44KB 30KB / +10%
libraries/browser-tracker-core/dist/index.mod
ule.js
+23.44KB 25KB / +10%
libraries/tracker-core/dist/index.module.js
+19.42KB 20KB / +10%
trackers/browser-tracker/dist/index.umd.min.j
s
+17.35KB 20KB / +10%
trackers/javascript-tracker/dist/sp.lite.js
+17.28KB 20KB / +10%
trackers/browser-tracker/dist/index.module.js
+3.49KB 5KB / +10%

Total files change +105.41KB 0%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history

@greg-el Greg Leonard (greg-el) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@matus-tomlein
Matus Tomlein (matus-tomlein) changed the base branch from master to release/4.0.2 November 11, 2024 15:18
@matus-tomlein
Matus Tomlein (matus-tomlein) merged commit e6e853a into release/4.0.2 Nov 11, 2024
@matus-tomlein
Matus Tomlein (matus-tomlein) deleted the issue/fix_post_path branch November 11, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants