Fill empty targetUrl for link clicks with "about:invalid" to avoid failed events and output a warning - #1360
Merged
Matus Tomlein (matus-tomlein) merged 2 commits intoOct 25, 2024
Conversation
…iled events and output a warning
Matus Tomlein (matus-tomlein)
requested review from
Greg Leonard (greg-el) and
Jethro Nederhof (jethron)
October 24, 2024 15:58
BundleMonFiles added (6)
Total files change +104.84KB 0% Final result: ✅ View report in BundleMon website ➡️ |
Jethro Nederhof (jethron)
approved these changes
Oct 25, 2024
Jethro Nederhof (jethron)
left a comment
Jethro Nederhof (jethron)
left a comment
Contributor
There was a problem hiding this comment.
Otherwise LGTM!
Contributor
|
Maybe also retitle the PR to |
Matus Tomlein (matus-tomlein)
changed the title
Matus Tomlein (matus-tomlein)
changed the title
Matus Tomlein (matus-tomlein)
deleted the
issue/link_click_tracking_empty_href
branch
October 25, 2024 11:41
Matus Tomlein (matus-tomlein)
added a commit
that referenced
this pull request
Oct 25, 2024
…iled events and output a warning (#1360)
Matus Tomlein (matus-tomlein)
added a commit
that referenced
this pull request
Oct 28, 2024
…iled events and output a warning (#1360)
Matus Tomlein (matus-tomlein)
added a commit
that referenced
this pull request
Oct 28, 2024
…iled events and output a warning (#1360)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case a click on a link with empty
hrefis tracked, setabout:nothingas thetargetUrlin the event to avoid the event failing validation.Also logs a
console.warnto help users identify and fix these issues.