Change the default value for keepalive to false - #1359
Merged
Matus Tomlein (matus-tomlein) merged 1 commit intoOct 24, 2024
Conversation
Matus Tomlein (matus-tomlein)
requested review from
Greg Leonard (greg-el) and
Jethro Nederhof (jethron)
October 23, 2024 19:24
BundleMonFiles added (6)
Total files change +104.79KB 0% Final result: ✅ View report in BundleMon website ➡️ |
Jethro Nederhof (jethron)
approved these changes
Oct 23, 2024
Jethro Nederhof (jethron)
left a comment
Jethro Nederhof (jethron)
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
All "solutions" to this problem continue to be cursed, I guess. 😅
Matus Tomlein (matus-tomlein)
deleted the
issue/keepalive_default_false
branch
October 24, 2024 07:10
Matus Tomlein (matus-tomlein)
added a commit
that referenced
this pull request
Oct 25, 2024
Matus Tomlein (matus-tomlein)
added a commit
that referenced
this pull request
Oct 28, 2024
Matus Tomlein (matus-tomlein)
added a commit
that referenced
this pull request
Oct 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR disables fetch keepalive by default.
The reason for this is the 64KB limit that browsers put on the keepalive requests. Although the default
maxPostBytesis under this limit so we shouldn't run into for single requests, the limit is shared for parallel requests. We have seen this when testing in internal apps that have multiple initialized trackers that send events at once – this caused the requests to go into a pending state and fail.A related problem was reported in #1355 – I think we were able to fix this for the case where there is a single tracker instance sending events, but not for the multiple tracker instances case. Since we can't fix it for that case, we can't keep the default setting to true.