Make base64 encoding an optional parameter in Node newTracker call - #1354
Merged
Matus Tomlein (matus-tomlein) merged 2 commits intoOct 18, 2024
Merged
Conversation
Matus Tomlein (matus-tomlein)
requested review from
Greg Leonard (greg-el) and
Jethro Nederhof (jethron)
October 15, 2024 06:21
Matus Tomlein (matus-tomlein)
added a commit
that referenced
this pull request
Oct 18, 2024
Matus Tomlein (matus-tomlein)
added a commit
that referenced
this pull request
Oct 18, 2024
Jethro Nederhof (jethron)
pushed a commit
to jethron/snowplow-javascript-tracker
that referenced
this pull request
Oct 25, 2024
Matus Tomlein (matus-tomlein)
added a commit
that referenced
this pull request
Oct 25, 2024
Matus Tomlein (matus-tomlein)
added a commit
that referenced
this pull request
Oct 28, 2024
Matus Tomlein (matus-tomlein)
added a commit
that referenced
this pull request
Oct 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the
encodeBase64parameter in thenewTrackercall of the Node tracker optional. It keeps the default true setting.