Disable b64 for SDJ data on POST requests from browsers by default - #1352
Merged
Jethro Nederhof (jethron) merged 1 commit intoOct 9, 2024
Merged
Conversation
Jethro Nederhof (jethron)
requested a review
from Matus Tomlein (matus-tomlein)
October 4, 2024 07:13
BundleMonFiles added (6)
Total files change +104.8KB 0% Final result: ✅ View report in BundleMon website ➡️ |
Matus Tomlein (matus-tomlein)
approved these changes
Oct 8, 2024
Matus Tomlein (matus-tomlein)
left a comment
Matus Tomlein (matus-tomlein)
left a comment
Contributor
There was a problem hiding this comment.
Yay! 🥳
Should we update the API docs in the TrackerConfiguration type to state the default is false for POST requests?
In POST requests this usually results in a smaller payload size, and is easier to debug. The node tracker shares this setting across multiple emitters that may not all use POST so we can't make this assumption there.
Jethro Nederhof (jethron)
force-pushed
the
b64-disable-post
branch
from
October 9, 2024 00:35
21cd75d to
8bddc3b
Compare
Matus Tomlein (matus-tomlein)
pushed a commit
that referenced
this pull request
Oct 25, 2024
…1352) In POST requests this usually results in a smaller payload size, and is easier to debug. The node tracker shares this setting across multiple emitters that may not all use POST so we can't make this assumption there.
Merged
Matus Tomlein (matus-tomlein)
pushed a commit
that referenced
this pull request
Oct 28, 2024
…1352) In POST requests this usually results in a smaller payload size, and is easier to debug. The node tracker shares this setting across multiple emitters that may not all use POST so we can't make this assumption there.
Matus Tomlein (matus-tomlein)
pushed a commit
that referenced
this pull request
Oct 28, 2024
…1352) In POST requests this usually results in a smaller payload size, and is easier to debug. The node tracker shares this setting across multiple emitters that may not all use POST so we can't make this assumption there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In POST requests this usually results in a smaller payload size, and is easier to debug. The node tracker shares this setting across multiple emitters that may not all use POST so we can't make this assumption there, because it is considerably less efficient when used for GET requests.