Support events on buttons/links/forms in ShadowDOMs - #1351
Merged
Jethro Nederhof (jethron) merged 2 commits intoOct 9, 2024
Conversation
Jethro Nederhof (jethron)
requested a review
from Matus Tomlein (matus-tomlein)
October 4, 2024 05:49
BundleMonFiles added (6)
Total files change +104.75KB 0% Final result: ✅ View report in BundleMon website ➡️ |
Matus Tomlein (matus-tomlein)
approved these changes
Oct 9, 2024
Matus Tomlein (matus-tomlein)
left a comment
Contributor
There was a problem hiding this comment.
LGTM! 👍
Matus Tomlein (matus-tomlein)
pushed a commit
that referenced
this pull request
Oct 25, 2024
* Support clicks on buttons/links in ShadowDOMs * Detect form events within ShadowRoots
Merged
Matus Tomlein (matus-tomlein)
pushed a commit
that referenced
this pull request
Oct 28, 2024
* Support clicks on buttons/links in ShadowDOMs * Detect form events within ShadowRoots
Matus Tomlein (matus-tomlein)
pushed a commit
that referenced
this pull request
Oct 28, 2024
* Support clicks on buttons/links in ShadowDOMs * Detect form events within ShadowRoots
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When DOM events on elements within Custom Components/ShadowRoots trigger against the
document, thetargetis set to the Custom Element/shadow host rather than the actual element that caused the event.This change adds support to the from/button/link tracking plugins to detect when this occurs, and use the first element from the Event's
composedPathinstead of thetarget. This enables them to see the actual even target and fire correctly in this scenario.For the Form tracker, only
focusevents are consideredcomposed, sochangeandsubmitevents don't actually get reported outside the shadow DOM. As a workaround, when thefocusevents occur, if enabled the change/submit event listeners are bound directly to the form (or field if it has no associated form) rather than just thedocument.