Use capture-phase listeners for button click tracking - #1348
Merged
Jethro Nederhof (jethron) merged 1 commit intoOct 9, 2024
Merged
Conversation
BundleMonFiles added (6)
Total files change +104.68KB 0% Final result: ✅ View report in BundleMon website ➡️ |
Matus Tomlein (matus-tomlein)
approved these changes
Oct 9, 2024
Matus Tomlein (matus-tomlein)
left a comment
Matus Tomlein (matus-tomlein)
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
Matus Tomlein (matus-tomlein)
pushed a commit
that referenced
this pull request
Oct 25, 2024
In v4 we switched the Form Tracking (#1329) and Link Click Tracking (#1325) plugins to using capture-phase event listeners instead of bubble-phase. This makes the same change for the Button Click Tracking plugin to make it consistent. This has caused issues for some clients historically, e.g. BCPF-1421 where pages stopping propagation of event bubbling prevented buttons being tracked.
Merged
Matus Tomlein (matus-tomlein)
pushed a commit
that referenced
this pull request
Oct 28, 2024
In v4 we switched the Form Tracking (#1329) and Link Click Tracking (#1325) plugins to using capture-phase event listeners instead of bubble-phase. This makes the same change for the Button Click Tracking plugin to make it consistent. This has caused issues for some clients historically, e.g. BCPF-1421 where pages stopping propagation of event bubbling prevented buttons being tracked.
Matus Tomlein (matus-tomlein)
pushed a commit
that referenced
this pull request
Oct 28, 2024
In v4 we switched the Form Tracking (#1329) and Link Click Tracking (#1325) plugins to using capture-phase event listeners instead of bubble-phase. This makes the same change for the Button Click Tracking plugin to make it consistent. This has caused issues for some clients historically, e.g. BCPF-1421 where pages stopping propagation of event bubbling prevented buttons being tracked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In v4 we switched the Form Tracking (#1329) and Link Click Tracking (#1325) plugins to using capture-phase event listeners instead of bubble-phase.
This makes the same change for the Button Click Tracking plugin to make it consistent.
This has caused issues for some clients historically, e.g. BCPF-1421 where pages stopping propagation of event bubbling prevented buttons being tracked.