Migrate html5 plugin to new media plugin - #1344
Merged
Greg Leonard (greg-el) merged 1 commit intoOct 8, 2024
Merged
Conversation
BundleMonFiles added (6)
Total files change +104.68KB 0% Final result: ✅ View report in BundleMon website ➡️ |
Greg Leonard (greg-el)
force-pushed
the
migrate-html5-plugin-to-new-media-plugin
branch
2 times, most recently
from
September 25, 2024 12:36
4ed9f55 to
612b066
Compare
Greg Leonard (greg-el)
marked this pull request as ready for review
September 25, 2024 14:27
Greg Leonard (greg-el)
requested review from
Jethro Nederhof (jethron) and
Matus Tomlein (matus-tomlein)
September 25, 2024 14:27
Greg Leonard (greg-el)
force-pushed
the
migrate-html5-plugin-to-new-media-plugin
branch
from
September 25, 2024 14:44
612b066 to
36c1910
Compare
Greg Leonard (greg-el)
force-pushed
the
migrate-html5-plugin-to-new-media-plugin
branch
2 times, most recently
from
October 7, 2024 15:19
771d6bf to
b55683b
Compare
Matus Tomlein (matus-tomlein)
left a comment
Matus Tomlein (matus-tomlein)
left a comment
Contributor
There was a problem hiding this comment.
Once we fix the integration tests and validate that things work, I am happy to approve this! The code looks great!
Greg Leonard (greg-el)
force-pushed
the
migrate-html5-plugin-to-new-media-plugin
branch
from
October 8, 2024 10:23
74f6c44 to
b51a4c1
Compare
Matus Tomlein (matus-tomlein)
approved these changes
Oct 8, 2024
Matus Tomlein (matus-tomlein)
left a comment
Matus Tomlein (matus-tomlein)
left a comment
Contributor
There was a problem hiding this comment.
LGTM, nice work! 👍
Just one more comment about the default capture events – either remove the defaults or add ping events there.
Greg Leonard (greg-el)
force-pushed
the
migrate-html5-plugin-to-new-media-plugin
branch
from
October 8, 2024 12:11
3115c56 to
6b5fb36
Compare
Greg Leonard (greg-el)
deleted the
migrate-html5-plugin-to-new-media-plugin
branch
October 8, 2024 12:34
Matus Tomlein (matus-tomlein)
pushed a commit
that referenced
this pull request
Oct 25, 2024
Merged
Matus Tomlein (matus-tomlein)
pushed a commit
that referenced
this pull request
Oct 28, 2024
Matus Tomlein (matus-tomlein)
pushed a commit
that referenced
this pull request
Oct 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the tracking for the HTML media plugin to use the Snowplow Media Tracking plugin. I've also copied the
DynamicContextchanges to the Media plugin present in the YouTube PR to send the HTML entities.API Changes:
idarg in the config passed by the user has been renamedvideoto be consistent with other media trackers, and avoid any confusion withidin the Media pluginHTMLMediaElement.