Skip to content

Export MediaEventType from media plugin (Close #1315) #1316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jack Keene (Jack-Keene) merged 4 commits into from
Jun 13, 2024
Merged

Export MediaEventType from media plugin (Close #1315) #1316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
71dc85c
expose MediaEventType from media plugin api
Jack-Keene Jun 6, 2024
ba823d4
rush change
Jack-Keene Jun 6, 2024
9f592f3
rush change
Jack-Keene Jun 6, 2024
1a4c7cc
formatting
Jack-Keene Jun 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ...hanges/@snowplow/browser-plugin-media/issue-export-media-event-type_2024-06-06-05-59.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@snowplow/browser-plugin-media",
"comment": "Expose MediaEventType",
"type": "none"
}
],
"packageName": "@snowplow/browser-plugin-media"
}
10 changes: 10 additions & 0 deletions common/changes/@snowplow/browser-tracker/issue-export-media-event-type_2024-06-06-05-59.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@snowplow/browser-tracker",
"comment": "Expose MediaEventType",
"type": "none"
}
],
"packageName": "@snowplow/browser-tracker"
}
18 changes: 13 additions & 5 deletions plugins/browser-plugin-media/src/api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import {
EventWithContext,
} from './types';

export { MediaAdBreakType as MediaPlayerAdBreakType };
export { MediaAdBreakType as MediaPlayerAdBreakType, MediaEventType };

const _trackers: Record<string, BrowserTracker> = {};
const _context: Record<string, SelfDescribingJson[]> = {};
Expand Down Expand Up @@ -396,7 +396,9 @@ export function trackMediaAdSkip(
trackers: Array<string> = Object.keys(_trackers)
) {
let { percentProgress } = args;
if (percentProgress !== undefined) { percentProgress = Math.floor(percentProgress); }
Comment thread
Jack-Keene marked this conversation as resolved.
if (percentProgress !== undefined) {
percentProgress = Math.floor(percentProgress);
}
track(
{
mediaEvent: {
Expand Down Expand Up @@ -506,7 +508,9 @@ export function trackMediaAdClick(
trackers: Array<string> = Object.keys(_trackers)
) {
let { percentProgress } = args;
if (percentProgress !== undefined) { percentProgress = Math.floor(percentProgress); }
if (percentProgress !== undefined) {
percentProgress = Math.floor(percentProgress);
}
track(
{
mediaEvent: {
Expand Down Expand Up @@ -534,7 +538,9 @@ export function trackMediaAdPause(
trackers: Array<string> = Object.keys(_trackers)
) {
let { percentProgress } = args;
if (percentProgress !== undefined) { percentProgress = Math.floor(percentProgress); }
if (percentProgress !== undefined) {
percentProgress = Math.floor(percentProgress);
}
track(
{
mediaEvent: {
Expand Down Expand Up @@ -563,7 +569,9 @@ export function trackMediaAdResume(
trackers: Array<string> = Object.keys(_trackers)
) {
let { percentProgress } = args;
if (percentProgress !== undefined) { percentProgress = Math.floor(percentProgress); }
if (percentProgress !== undefined) {
percentProgress = Math.floor(percentProgress);
}
track(
{
mediaEvent: {
Expand Down