Skip to content

Fix newTracker optional configuration typing #1237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Peter Perlepes (igneel64) merged 1 commit into from
Oct 13, 2023
Merged

Fix newTracker optional configuration typing #1237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ...anges/@snowplow/browser-tracker/fix-remove-newTracker-faulty-typing_2023-09-13-09-52.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@snowplow/browser-tracker",
"comment": "Fix newTracker typing for better understanding of arguments",
"type": "none"
}
],
"packageName": "@snowplow/browser-tracker"
}
2 changes: 1 addition & 1 deletion trackers/browser-tracker/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ const state = typeof window !== 'undefined' ? createSharedState() : undefined;
* @param endpoint - Collector endpoint in the form collector.mysite.com
* @param configuration - The initialisation options of the tracker
*/
export function newTracker(trackerId: string, endpoint: string, configuration: TrackerConfiguration = {}) {
export function newTracker(trackerId: string, endpoint: string, configuration?: TrackerConfiguration) {
if (state) {
return addTracker(trackerId, trackerId, `js-${version}`, endpoint, state, configuration);
} else {
Expand Down