Fix newTracker typing to accurately return null or undefined (fix #1167)

[Peter Perlepes (igneel64)]

Fix correct typing issue for newTracker possibly returning:

• null when a tracker is already initialized with the same tracker id.
• undefined when we are not in a browser context.

(close #1167)

[bundlemon]

BundleMon

Files added (6)

Status	Path	Size	Limits
✅	libraries/browser-tracker-core/dist/index.mod ule.js	+25.21KB	26KB / +10%
✅	trackers/javascript-tracker/dist/sp.js	+24.22KB	25KB / +10%
✅	trackers/javascript-tracker/dist/sp.lite.js	+14.52KB	15KB / +10%
✅	trackers/browser-tracker/dist/index.umd.min.j s	+14.36KB	15KB / +10%
✅	libraries/tracker-core/dist/index.module.js	+13.36KB	15KB / +10%
✅	trackers/browser-tracker/dist/index.module.js	+3.51KB	5KB / +10%

Total files change +95.17KB 0%

Final result: ✅

View report in BundleMon website ➡️

---

Current branch size history

[Matus Tomlein (matus-tomlein)]

Looks good! I'm just wondering whether we can release this in v3 or should wait for v4. I know that it doesn't change the behaviour of the tracker, but the change in the type can cause some user code to produce typescript errors with handling the null or undefined that might have not been produced before. I think this could be considered a breaking as users would need to change how they use the result of newTracker(). So my opinion is that we should release this in v4.

[Peter Perlepes (igneel64)]

Matus Tomlein (@matus-tomlein)
Yeap had the same thought and was waiting for some feedback. Will point to v4