Skip to content

Update browser targets for compilation (closes #1131) - #1132

Merged
Peter Perlepes (igneel64) merged 1 commit into
release/4.0.0from
feature/1131-update-browser-support
Jan 9, 2023
Merged

Update browser targets for compilation (closes #1131)#1132
Peter Perlepes (igneel64) merged 1 commit into
release/4.0.0from
feature/1131-update-browser-support

Conversation

@igneel64

Copy link
Copy Markdown
Contributor

Based on our internal data and open source information the first proposal for the v4 compilation targets is the one presented.

Highlights

  • Dropping support for IE9 and IE10
  • Minimum Safari is 9.1
  • 'Evergreen' type browsers are bumped

Notes

  • Our compiled artifacts do not seem to change after the bump.

@bundlemon

bundlemon Bot commented Dec 22, 2022

Copy link
Copy Markdown

BundleMon

Files added (6)
Status Path Size Limits
libraries/browser-tracker-core/dist/index.mod
ule.js
+23.8KB 25KB / +10%
trackers/javascript-tracker/dist/sp.js
+23.49KB 25KB / +10%
trackers/javascript-tracker/dist/sp.lite.js
+14.2KB 15KB / +10%
trackers/browser-tracker/dist/index.umd.min.j
s
+14.05KB 15KB / +10%
libraries/tracker-core/dist/index.module.js
+13.36KB 15KB / +10%
trackers/browser-tracker/dist/index.module.js
+3.46KB 5KB / +10%

Total files change +92.35KB 0%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Jack-Keene Jack Keene (Jack-Keene) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread .browserslistrc Outdated
@igneel64
Peter Perlepes (igneel64) force-pushed the feature/1131-update-browser-support branch from 32a9d0d to 426a8a8 Compare January 4, 2023 14:00

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Out of scope for this PR, but there are a number of places where we can also now improve the code by removing IE<11.

A couple that quickly spring to mind:

  • The out queue, no need for Image any more, it can all be XHR.
  • Integration Tests ;-)
  • Bumping UUID library to latest

I'm also a little surprised the output didn't change. The underlying library uses this file to figure out if typescript should transpile to ES3 or ES5. It always picked ES3, but I'd have thought we'd have ended up with ES5 now. I can't quite remember how, but using the TS lib we have and running it in node, you can feed this file into it and it outputs the TS version it selects.

@igneel64

Peter Perlepes (igneel64) commented Jan 6, 2023

Copy link
Copy Markdown
Contributor Author

Paul Boocock (@paulboocock)
About ES3-ES5, even with the old settings we were in ES5 supported environments https://caniuse.com/es5 .
Did you find any hint that this compiled down to ES3 in the past ?

If we said we support ES3, we would need to polyfill methods such as Array.prototype.map, Object.keys etc. which we already use in our code.

@igneel64
Peter Perlepes (igneel64) merged commit 086d2f0 into release/4.0.0 Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants