Update browser targets for compilation (closes #1131) - #1132
Conversation
BundleMonFiles added (6)
Total files change +92.35KB 0% Final result: ✅ View report in BundleMon website ➡️ |
Matus Tomlein (matus-tomlein)
left a comment
There was a problem hiding this comment.
LGTM!
32a9d0d to
426a8a8
Compare
Paul Boocock (paulboocock)
left a comment
There was a problem hiding this comment.
LGTM. Out of scope for this PR, but there are a number of places where we can also now improve the code by removing IE<11.
A couple that quickly spring to mind:
- The out queue, no need for Image any more, it can all be XHR.
- Integration Tests ;-)
- Bumping UUID library to latest
I'm also a little surprised the output didn't change. The underlying library uses this file to figure out if typescript should transpile to ES3 or ES5. It always picked ES3, but I'd have thought we'd have ended up with ES5 now. I can't quite remember how, but using the TS lib we have and running it in node, you can feed this file into it and it outputs the TS version it selects.
|
Paul Boocock (@paulboocock) If we said we support ES3, we would need to polyfill methods such as Array.prototype.map, Object.keys etc. which we already use in our code. |
Based on our internal data and open source information the first proposal for the v4 compilation targets is the one presented.
Highlights
Notes