Update rush version, upgrade Node.js GA action version, remove Node 12 (closes #1093) - #1094
Merged
Peter Perlepes (igneel64) merged 1 commit intoSep 8, 2022
Conversation
Snowplow CLA bot (snowplowcla)
added
the
cla:no
Peter Perlepes (igneel64)
added
category:setup
Peter Perlepes (igneel64)
requested review from
Matus Tomlein (matus-tomlein) and
Paul Boocock (paulboocock)
and removed request for
Matus Tomlein (matus-tomlein)
August 29, 2022 16:28
Paul Boocock (paulboocock)
approved these changes
Sep 1, 2022
| ### Maintainer quick start | ||
|
|
||
| Assuming [git](https://git-scm.com/downloads), [Node.js 12 LTS or 14 LTS](https://nodejs.org/en/download/releases/) are installed. | ||
| Assuming [git](https://git-scm.com/downloads), [Node.js14 or 16](https://nodejs.org/en/download/releases/) are installed. |
There was a problem hiding this comment.
Suggested change
| Assuming [git](https://git-scm.com/downloads), [Node.js14 or 16](https://nodejs.org/en/download/releases/) are installed. | |
| Assuming [git](https://git-scm.com/downloads), [Node.js 14 or 16](https://nodejs.org/en/download/releases/) are installed. |
|
If I'm being nitpicky, I'd perhaps shorten this commit name a little but that might just be me. "Upgrade Node.js and rush versions" is probably descriptive enough. |
Peter Perlepes (igneel64)
force-pushed
the
feature/1093-update-rush-upgrade-node
branch
from
September 1, 2022 10:30
cee07eb to
2f5e48e
Compare
Matus Tomlein (matus-tomlein)
approved these changes
Sep 1, 2022
Matus Tomlein (matus-tomlein)
left a comment
Matus Tomlein (matus-tomlein)
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
Peter Perlepes (igneel64)
changed the title
Peter Perlepes (igneel64)
changed the base branch from
master
to
release/3.6.0
September 8, 2022 13:07
Peter Perlepes (igneel64)
deleted the
feature/1093-update-rush-upgrade-node
branch
September 8, 2022 13:11
Peter Perlepes (igneel64)
added a commit
that referenced
this pull request
Sep 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
rush-pnpmavailable.Closes #1093 (See for more info)
Note for existing maintainers
Run:
rush versionnpm install --global @microsoft/rushrush-pnpm auditor some other command