Make newDocumentTitle variable local

[chuwy]

snowplow-javascript-tracker/src/js/tracker.js

Line 1305 in c67ec23

newDocumentTitle = documentAlias.title;

Trying to figure out why it was made global.

[brightwrite-admin]

v2.7.2 and 2.8.2. Throws an exception newDocumentTitle is not defined now when you use enableActivityTracking.

[brightwrite-admin]

Anton Parkhomenko (@chuwy) Fixed. I had issues with Safari and Chrome (latest version). I guess it might be last changes in JS engine. enableActivityTracking feature didn't work there.

[chuwy]

Hello brightwrite-admin, I just checked it in both latest Chrome and Safari and enableActivityTracking seems to work in both stable versions.

I think it might be problem with one of plugins installed on your browser. Otherwise this indeed can be a quite serious bug.

[brightwrite-admin]

Thanks for checking it Anton Parkhomenko (@chuwy)!

I don't think it's an extension, as I don't have any extensions installed in Safari.
What I think causes this problem is the way how I install SnowPlow, it's a WebPack module.
I believe the problem might be in hoisting. It's hard to debug, but changing this var to local fixes the issue. I checked this global var is not used anywhere.