Skip to content

Specify the key for 'null or empty value detected' payload log (close #277)#263

Merged
Miranda Wilson (mscwilson) merged 1 commit intosnowplow:release/0.11.0from
b-ryan:null-empty-log-improvement
Nov 30, 2021
Merged

Specify the key for 'null or empty value detected' payload log (close #277)#263
Miranda Wilson (mscwilson) merged 1 commit intosnowplow:release/0.11.0from
b-ryan:null-empty-log-improvement

Conversation

@b-ryan
Copy link
Copy Markdown
Contributor

There's no way to know which key is causing the "null or empty value detected" log, so this change makes this log possible to debug.

@snowplowcla
Copy link
Copy Markdown

Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://docs.snowplowanalytics.com/docs/contributing/contributor-license-agreement/ to learn more and sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

@snowplowcla Snowplow CLA bot (snowplowcla) added the cla:no [Auto generated] Snowplow Contributor License Agreement has not been signed. label Jan 27, 2021
@b-ryan
Copy link
Copy Markdown
Contributor Author

I signed it

@snowplowcla
Copy link
Copy Markdown

Confirmed! Buck Ryan (@b-ryan) has signed the Contributor License Agreement. Thanks so much.

@snowplowcla Snowplow CLA bot (snowplowcla) added cla:yes [Auto generated] Snowplow Contributor License Agreement has been signed. and removed cla:no [Auto generated] Snowplow Contributor License Agreement has not been signed. labels Jan 27, 2021
@paulboocock
Copy link
Copy Markdown
Contributor

Thanks for the PR Buck Ryan (@b-ryan)

I'm looking at doing a small release in february so I'll include this then.

@mscwilson Miranda Wilson (mscwilson) changed the base branch from master to release/0.11.0 November 30, 2021 11:06
@mscwilson Miranda Wilson (mscwilson) changed the title specify the key in the 'null or empty value detected' log Specify the key for 'null or empty value detected' payload log (close #277) Nov 30, 2021
@mscwilson
Copy link
Copy Markdown
Contributor

Thanks again for this PR Buck Ryan (@b-ryan), and sorry for the delay in merging it in. We'll be releasing v0.11.0 including your change soon.

@mscwilson Miranda Wilson (mscwilson) merged commit f19fcb4 into snowplow:release/0.11.0 Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla:yes [Auto generated] Snowplow Contributor License Agreement has been signed.

Development

Successfully merging this pull request may close these issues.

4 participants