Allow Emitter to use a custom ExecutorService (close #278)#259
Merged
Miranda Wilson (mscwilson) merged 1 commit intosnowplow:release/0.11.0from Nov 30, 2021
Conversation
This commit allows a user to use its own ExecutorService in the Emitter to have a more granular control over threads created by an Emitter.
Snowplow CLA bot (snowplowcla)
added
the
cla:yes
Paul Boocock (paulboocock)
approved these changes
Jul 9, 2020
Contributor
Paul Boocock (paulboocock)
left a comment
Paul Boocock (paulboocock)
left a comment
There was a problem hiding this comment.
LGTM
Thank you for the contribution, we'll release this with 0.11.0.
|
any plan for the 0.11.0 release? |
Contributor
|
Hi Davide Savazzi (@svzdvd) |
Miranda Wilson (mscwilson)
changed the base branch from
master
to
release/0.11.0
Miranda Wilson (mscwilson)
changed the title
Contributor
|
Thanks again for your contribution. It's now been merged in for release 0.11.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit allows a user to use its own ExecutorService in the Emitter
to have a more granular control over threads created by an Emitter.