Set Emitter's threads name for easier debugging (close #280)#258
Merged
Miranda Wilson (mscwilson) merged 2 commits intosnowplow:issue/280-set_emitter_thread_namesfrom Nov 30, 2021
Conversation
Add a ThreadFactory to the Emitter executor service to set a custom name for threads that are created when calling execute(). Set a name for the buffer consumer thread in the BatchEmitter. Naming these threads can be useful when investigating a thread dump, or for monitoring purpose.
Snowplow CLA bot (snowplowcla)
added
the
cla:yes
|
Would be great to have this feature merged in. (I found this PR as I was checking that an open one didn't exist already before submitting one myself) |
Contributor
|
Hey Andy May (@andy-may-at) |
Miranda Wilson (mscwilson)
changed the base branch from
master
to
release/0.11.0
Miranda Wilson (mscwilson)
changed the title
Miranda Wilson (mscwilson)
changed the base branch from
release/0.11.0
to
issue/280-set_emitter_thread_names
Miranda Wilson (mscwilson)
merged commit 6318195
into
snowplow:issue/280-set_emitter_thread_names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a ThreadFactory to the Emitter executor service to set
a custom name for threads that are created when calling execute().
Set a name for the buffer consumer thread in the BatchEmitter.
Naming these threads can be useful when investigating a thread dump, or
for monitoring purpose.