-
Notifications
You must be signed in to change notification settings - Fork 35
Restore Emitter callbacks for success and failure #339
Copy link
Copy link
Closed
Labels
category:breaking_changeA breaking change will be introduced if this issue is completed.A breaking change will be introduced if this issue is completed.category:data_lossData loss might be happening.Data loss might be happening.status:completedCompleted - but might not be released yet.Completed - but might not be released yet.type:enhancementNew features or improvements to existing features.New features or improvements to existing features.
Milestone
Description
Metadata
Metadata
Assignees
Labels
category:breaking_changeA breaking change will be introduced if this issue is completed.A breaking change will be introduced if this issue is completed.category:data_lossData loss might be happening.Data loss might be happening.status:completedCompleted - but might not be released yet.Completed - but might not be released yet.type:enhancementNew features or improvements to existing features.New features or improvements to existing features.
Older versions of the Java tracker had
RequestCallback. Users could provide methods to call when events were successfully sent, or failed to send, via theRequestCallbackinterface. TheonFailure()method could be given a list ofEventobjects, allowing the user to retrack them as if they were brand new. This was the only way to retry the requests.Since v0.12.0, the Java tracker automatically retries events indefinitely. As part of the restructuring,
RequestCallbackwas removed.Callbacks can still be useful, however, so let's reinstate with a better implementation.