-
Notifications
You must be signed in to change notification settings - Fork 35
Choose HTTP response codes not to retry #316
Copy link
Copy link
Closed
Labels
category:data_lossData loss might be happening.Data loss might be happening.status:completedCompleted - but might not be released yet.Completed - but might not be released yet.type:enhancementNew features or improvements to existing features.New features or improvements to existing features.
Milestone
Metadata
Metadata
Assignees
Labels
category:data_lossData loss might be happening.Data loss might be happening.status:completedCompleted - but might not be released yet.Completed - but might not be released yet.type:enhancementNew features or improvements to existing features.New features or improvements to existing features.
Type
Fields
Give feedbackNo fields configured for issues without a type.
Issue #156 added retry to the Emitter. When an attempt to send is made, all 2xx HTTP response codes are considered successful. The event payloads are deleted from the tracker. Anything other than 2xx is considered a failure; the event payloads are returned to the buffer. Attempts to send will continue indefinitely, but with an increasing delay between attempts.
Certain response codes, especially those within 4xx, should perhaps not be retried.
Eventually, it would be good to create a RetryPolicy with complex options, and the ability to start and stop tracking, and change the collector URL while running. As a starting point, let's improve the retry mechanism by allowing users to choose which response codes should be fatal.