-
Notifications
You must be signed in to change notification settings - Fork 35
Rename bufferSize to batchSize #306
Copy link
Copy link
Closed
Labels
category:breaking_changeA breaking change will be introduced if this issue is completed.A breaking change will be introduced if this issue is completed.status:completedCompleted - but might not be released yet.Completed - but might not be released yet.type:enhancementNew features or improvements to existing features.New features or improvements to existing features.
Milestone
Description
Metadata
Metadata
Assignees
Labels
category:breaking_changeA breaking change will be introduced if this issue is completed.A breaking change will be introduced if this issue is completed.status:completedCompleted - but might not be released yet.Completed - but might not be released yet.type:enhancementNew features or improvements to existing features.New features or improvements to existing features.
The Emitter property
bufferSizespecifies the desired number of events in one POST request, not the size or capacity of the buffer. This is obviously confusing. It will be even more confusing soon since the Emitter will get a constructor option forbufferCapacityi.e. the maximum size of the buffer.It refers to the batch size, so
bufferSizeshould be renamedbatchSize.