-
Notifications
You must be signed in to change notification settings - Fork 35
Refactor TrackerEvents for event payload creation #291
Copy link
Copy link
Closed
Labels
category:breaking_changeA breaking change will be introduced if this issue is completed.A breaking change will be introduced if this issue is completed.status:completedCompleted - but might not be released yet.Completed - but might not be released yet.type:enhancementNew features or improvements to existing features.New features or improvements to existing features.
Milestone
Metadata
Metadata
Assignees
Labels
category:breaking_changeA breaking change will be introduced if this issue is completed.A breaking change will be introduced if this issue is completed.status:completedCompleted - but might not be released yet.Completed - but might not be released yet.type:enhancementNew features or improvements to existing features.New features or improvements to existing features.
The tracker
track()method currently creates TrackerEvents; they contain Subject, Prameter and Event objects. These TrackerEvents are used right up until the events are being sent, when they are TrackerPayloads are generated from them.TrackerEvents were added in PR #226 as part of a larger refactoring. The idea was that for a failed events callback, it would be easy to replay the Event (wrapped in the TrackerEvent) back into the tracker. The event storage is being overhauled for this release (0.12.0), and retry added. It's a good time to change how events and payloads are created.
Refactor TrackerEvents and maybe add a thread/threadpool to the tracker.