fix(ci): restore build & Install workflows and stabilize integration tests - #99
Merged
Merged
Conversation
The build and Install workflows were failing on two independent issues: - Deprecated GitHub Actions caused hard failures. `actions/cache@v2` is auto-failed by GitHub; `actions/checkout@v2/v3`, `actions/setup-java@v1`, and `microsoft/setup-msbuild@v1.1` are deprecated. Bump to current major versions (checkout@v4, cache@v4, setup-java@v4 with required distribution, setup-msbuild@v2) and replace the removed `set-output` command with `$GITHUB_OUTPUT`. - CMake 4.x rejects the pinned nlohmann/json (its CMakeLists declared cmake_minimum_required < 3.5) and no longer allows the deprecated `FetchContent_Populate`. Bump nlohmann/json to 3.12.0 (first CMake-4 compatible release) in both the FetchContent pin and the Conan file so the EXACT version match in the installed config stays consistent, and switch the SQLite amalgamation to `FetchContent_MakeAvailable` with `DOWNLOAD_EXTRACT_TIMESTAMP`. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Two environment-driven failures surfaced once the workflows ran again on current runners: - Windows MSBuild failed with MSB1009 because it hardcoded `snowplow.sln`, but the newer Visual Studio 18 (2026) generator no longer produces a solution at that path. Replace the MSBuild invocation with the generator-agnostic `cmake --build . --config Debug`, which locates the solution regardless of name. - The Install workflow's `turtlebrowser/get-conan` action runs `pip3 install`, which now fails with an externally-managed-environment (PEP 668) error on GitHub runners. Install Conan via `pipx install conan` instead; pipx is preinstalled on all hosted runners and isolates the venv. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…eeps Micro processes events asynchronously, so a fixed `sleep_for(1000ms)` before reading counts races it on slower or busier CI runners and causes intermittent failures (AISP-1546; recurrence of CSTMR-1942). A prior sleep-duration increase did not hold. Add `Micro::wait_for_good_and_bad_count(expected_good, expected_bad, timeout)`, which polls the existing `/micro/all` helper every 100ms until the expected counts are reached or a 10s timeout elapses, then returns the last observed counts. Callers keep asserting exact counts, so unexpected extra events are still caught. Replace the fixed waits at each assertion site; the 500ms spacing between the two cookie-test events is intentional (distinct collector timestamps) and is kept and commented. Verified locally against Snowplow Micro 1.1.2: integration section passes and now completes in ~0.3s instead of ~4.5s of fixed sleeps. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildandInstallGitHub Actions workflows, which had been failing on every push tomaster.Changes
Deprecated GitHub Actions → current versions
actions/cache@v2→v4(v2 is auto-failed by GitHub — this was killing thebuildjobs in seconds)actions/checkout@v2/v3→v4,actions/setup-java@v1→v4(added requireddistribution: temurin),microsoft/setup-msbuild@v1.1→v2::set-outputcommand with$GITHUB_OUTPUTinrelease.ymlCMake 4.x compatibility (the real build failure)
3.12.0(its first CMake-4-compatible release) in both the FetchContent pin (CMakeLists.txt) andexamples/conanfile.py— they must agree because the installed CMake config does anEXACTversion matchFetchContent_Populatefor the SQLite amalgamation withFetchContent_MakeAvailable+DOWNLOAD_EXTRACT_TIMESTAMPRunner-environment fixes
msbuild .\snowplow.sln(which the new VS 2026 generator broke) with generator-agnosticcmake --build . --config Debugturtlebrowser/get-conanaction (fails with PEP 668externally-managed-environment) withpipx install conanIntegration test stability (AISP-1546)
Micro::wait_for_good_and_bad_count(expected_good, expected_bad, timeout=10s), which polls the existing/micro/allhelper every 100ms until the expected counts are reached instead of racing Micro's async processing with a fixedsleep_for(1000ms)Testing
build(linux/mac/windows) andInstall(all 11 combinations)Notes
/micro/all|good|badConsole endpoints are deliberately not used as they are unavailable with persistent storage.🤖 Generated with Claude Code