Fix SQLite storage test for SQLite >= 3.39.0 - #94
Merged
Matus Tomlein (matus-tomlein) merged 1 commit intoJan 29, 2026
Merged
Conversation
This test constructs an SqliteStorage object with a bogus database name, and expects to see a failure. The internal call to sqlite3_open succeeds with "~/" when linking against versions of SQLite from 3.39.0 onwards (and creates a file with the name "~" in the working directory). In these newer versions, trailing slashes are stripped from the input, likely as a byproduct of the following change: >The unix os interface resolves all symbolic links in database filenames >to create a canonical name for the database before the file is opened. See https://sqlite.org/changes.html. Using "." produces the expected failure.
Snowplow CLA bot (snowplowcla)
added
the
cla:yes
Matus Tomlein (matus-tomlein)
approved these changes
Jan 29, 2026
Matus Tomlein (matus-tomlein)
left a comment
Matus Tomlein (matus-tomlein)
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test constructs an
SqliteStorageobject with a bogus database name, and expects to see a failure. The internal call tosqlite3_opensucceeds with"~/"when linking against versions of SQLite from 3.39.0 onwards, however (and creates a file with the name"~"in the working directory). In these newer versions, trailing slashes are stripped from the input, likely as a byproduct of the following change (from the changelog):Using
"."produces the expected failure.