Fix failing importData tests from PR #678 (IndexedDB support)#685
Closed
Fix failing importData tests from PR #678 (IndexedDB support)#685
Conversation
…ersioned format Co-authored-by: sheepzh <19428473+sheepzh@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Review pull request #678 for changes
Fix failing importData tests from PR #678 (IndexedDB support)
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #678 refactored
importDatato require a versioned export format (__meta__+ typed namespaces), but the tests still passed rawchrome.storagedata directly, causing two failures: merge rules returning[]andallowDelaybeingundefinedinstead offalse.Infrastructure added
src/util/guard.ts—isRecord,isOptionalInt,isVector2type guards viatypescript-guardsrc/database/common/migratable.ts—isExportData,isLegacyVersion,extractNamespacefor versioned import/export logicsrc/database/types.d.ts—BrowserMigratable<N>interface for databases that support import/exporttypes/timer/backup.d.ts—ExportMetaandExportDatatypes for the versioned formatDatabase updates
merge-rule-databaseandlimit-databasenow routeimportDatabased on version:Legacy path preserves the original key-based chrome storage import. Both databases also expose
exportData()implementingBrowserMigratable.Test fix
Added
test/database/migratable.tswithmockLegacyDatato wrap raw storage snapshots with__meta__: { version: "3.8.15" }, routing them through the legacy import path:🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.