Specify NodeJS 12 as a requirement.

[StevenBlack]

When I installed this for local use, I got several warnings and errors. Upgrading to NodeJS latest (version 12) fixed all the issues.

[StevenBlack]

I have a bit more info on this.

On another machine I have Node v 13.3. When I install according to instructions:

npm install coronavirus-tracker-cli -g

I get the following warnings:

npm WARN notsup Unsupported engine for [email protected]: wanted: {"node":"12.x"} (current: {"node":"13.3.0","npm":"6.13.2"})
npm WARN notsup Not compatible with your version of node/npm: [email protected]

I am therefore submitting an additional modification to package.json.engines to include NodeJS versions above 12.x.

[XhmikosR]

This unfortunately means it will affect the version used by the current live Heroku deployment too :/
Scratch that it seems this project is hosted on Now.

Node.js 13.x isn't stable yet and Node.js 14 will be the next LTS which is planned to be released on April, see
https://nodejs.org/en/about/releases/ and nodejs/node#32181

[StevenBlack]

I feel I need to clarify.

• I first attempted to install on a kitchen-counter Mac, an older retired laptop, that was running Node 8. It wouldn't install. After upgrading the kitchen Mac to Node 12 (latest LTS), everything works great. So I added the commit to document Node 12 in the Install section of the Readme.

• I later installed on my production Mac which is running Node 13. It installed with a warning (see above) Not compatible with your version of node/npm. This runs just fine on Node 13, which is why I made the second commit to modify package.json.engines because the hard-constraint on Node 12 is not appropriate. This will be fine on Node 12+.

[XhmikosR]

Yeah, no worries, this should be fine :)

At first I thought the app was deployed on Heroku, which takes into consideration the engines version to choose which version of Node.js is used in production.

But this app is using Zeit Now. Now, I'm not sure if Zeit Now is using the same mechanism. If so, then this change means that the version of the deployed site will be 13.x, which is probably not intended for production.

[vercel]

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/sagark/coronavirus-tracker/4ivsg8xr0
✅ Preview: https://coronavirus-tracker-git-fork-stevenblack-master.sagark.now.sh