add basic CLI support, --emojis flag, [country] positional argument #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagarkarira
reviewed
Mar 17, 2020
Owner
sagarkarira
left a comment
sagarkarira
left a comment
There was a problem hiding this comment.
Wow, thanks @xandris. I will review and merge this as soon as I wake up. 😃
Contributor
Author
|
Glad to help! Feel free to change anything or ask me to; I realize this is a lot of merge request to drop unbidden lol |
Owner
|
@xandris I made some formatting changes. I've merged the PR and I've published to npm. You can check it out. |
Contributor
Author
|
Nice! Love the yargs colors :) I think the |
This was referenced Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses yargs to parse options and implements the flags at the helpers level. Exposes per-country stats to the CLI.
--coloris defined in yargs, but chalk supports it natively. Country code normalization is shuffled around to avoid repeating it in the CLI and webapp code.