Skip to content

wip: jinja tempaltes with bootstrap 4.x #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

wip: jinja tempaltes with bootstrap 4.x #1

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4076338
add html_kwargs to submit button
aparcar Dec 1, 2018
26dcf6e
update bootstrap to 4.1
aparcar Dec 1, 2018
9a64b84
improve alerts
aparcar Dec 1, 2018
15d7a98
fixup top navbar with search
aparcar Dec 1, 2018
12ae538
fixup and indent navigation
aparcar Dec 1, 2018
c4d9b38
issue.edit as bootstrap styled form
aparcar Dec 1, 2018
2ef09bc
add gitignore
aparcar Dec 2, 2018
764adab
fixup pagination
aparcar Dec 2, 2018
345c0ac
fixup sort.html
aparcar Dec 2, 2018
e2900d3
fixup issue.search, user.index and user.item
aparcar Dec 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
add html_kwargs to submit button 
now submit buttons can have individual attributes as well. Useful for
the bootstrap style where submit buttons require a class to look nice.
  • Loading branch information
@aparcar
aparcar committed Dec 2, 2018
commit 407633818131f7e5af4572ad20b006c60814dca3
15 changes: 11 additions & 4 deletions roundup/cgi/templating.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -762,9 +762,12 @@ def classhelp(self, properties=None, label=''"(list)", width='500',
(help_url, onclick, cgi_escape_attrs(**html_kwargs),
self._(label))

def submit(self, label=''"Submit New Entry", action="new"):
def submit(self, label=''"Submit New Entry", action="new", html_kwargs={}):
""" Generate a submit button (and action hidden element)

"html_kwargs" specified additional html args for the
generated html <select>

Generate nothing if we're not editable.
"""
if not self.is_edit_ok():
Expand All @@ -775,7 +778,8 @@ def submit(self, label=''"Submit New Entry", action="new"):
'\n' + \
self.input(type="hidden", name="@action", value=action) + \
'\n' + \
self.input(type="submit", name="submit_button", value=self._(label))
self.input(type="submit", name="submit_button", value=self._(label),
**html_kwargs)

def history(self):
if not self.is_view_ok():
Expand Down Expand Up @@ -905,9 +909,12 @@ def is_retired(self):
"""Is this item retired?"""
return self._klass.is_retired(self._nodeid)

def submit(self, label=''"Submit Changes", action="edit"):
def submit(self, label=''"Submit Changes", action="edit", html_kwargs={}):
"""Generate a submit button.

"html_kwargs" specified additional html args for the
generated html <select>

Also sneak in the lastactivity and action hidden elements.
"""
return self.input(type="hidden", name="@lastactivity",
Expand All @@ -919,7 +926,7 @@ def submit(self, label=''"Submit Changes", action="edit"):
self.input(type="hidden", name="@action", value=action) + \
'\n' + \
self.input(type="submit", name="submit_button",
value=self._(label))
value=self._(label), **html_kwargs)

def journal(self, direction='descending'):
""" Return a list of HTMLJournalEntry instances.
Expand Down