issue2550953: Patch: fix for context.is_view_ok check in jinja2 template

Form controls are displayed when anonymous views indexes but is
denied access. (patch by Anton Schur applied by John Rouillard)

Author: rouilj

CHANGES.txt

@@ -460,6 +460,9 @@ Fixed:
 - query.item.html was missing checks to verify that a query should
   be visible to the user. This is fixed and users can only view
   queries that they own or that are not private. (John Rouillard)
+- issue2550953: Patch: fix for context.is_view_ok check in jinja2 template
+  Form controls are displayed when anonymous views indexes but is
+  denied access. (patch by Anton Schur applied by John Rouillard)
 
 2016-01-11: 1.5.1
 

share/roundup/templates/jinja2/html/_generic.index.html

@@ -12,7 +12,7 @@
 
   {% include 'layout/permission.html' %}
 
-  {% if context.is_view_ok %}
+  {% if context.is_view_ok() %}
     <p class="form-help">{{ i18n.gettext('
      You may edit the contents of the
      class using this form. Commas, newlines and double quotes (") must be

share/roundup/templates/jinja2/html/issue.index.html

@@ -12,7 +12,7 @@
 
   {% include 'layout/permission.html' %}
 
-  {% if context.is_view_ok %}
+  {% if context.is_view_ok() %}
     {% if context.list() %}
       <table class='table'>
         <tr class='info'>
@@ -42,13 +42,7 @@
           </tr>
         {% endfor %}
       </table>
-    {% else %}
-      <p class='text-error'>{{ i18n.gettext('There are no issues yet!') }}</p>
-    {% endif %}
-  {% endif %}
-
-  {% include 'layout/pagination.html' %}
-
+      {% include 'layout/pagination.html' %}
   <div class='row-fluid'> 
     <div class='pull-right'>
       <a class='btn btn-success'
@@ -60,4 +54,10 @@
 
   {% include 'layout/sort.html' %}
 
+    {% else %}
+      <p class='text-error'>{{ i18n.gettext('There are no issues yet!') }}</p>
+    {% endif %}
+
+  {% endif %}
+
 {% endblock %}