Skip to content

Commit 2ef5b27

Browse files
committed
Schema updates for 1.6.0:
Make sure that user can view labelprop on classes (REQUIRED) Make sure user can see id property for file and msg. This allows the display code to loop over the id's in the file and msg multilinks so that the messages/files are displayed when viewing the issue. Allow anon to search user so "Show Unassigned" works for anonymous role/user. Allow all users to search creator property of query. This allows query edit to work properly. Assign Retire and Restore permissions for query to users.
1 parent aab9576 commit 2ef5b27

File tree

1 file changed

+17
-1
lines changed

1 file changed

+17
-1
lines changed

website/issues/schema.py

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ def __call__(self, db, userid, itemid):
181181
for cl in ('file', 'msg'):
182182
p = db.security.addPermission(name='View', klass=cl,
183183
description="allowed to see metadata object regardless of spam status",
184-
properties=('creation', 'activity',
184+
properties=('id', 'creation', 'activity',
185185
'creator', 'actor',
186186
'name', 'spambayes_score',
187187
'spambayes_misclassified',
@@ -268,6 +268,10 @@ def may_edit_file(db, userid, itemid):
268268
# Coordinator may view all user properties.
269269
db.security.addPermissionToRole('Coordinator', 'View', 'user')
270270

271+
# allow "Show Unassigned" link to work for anon
272+
p = db.security.addPermission(name='Search', klass='user')
273+
db.security.addPermissionToRole ('Anonymous', p)
274+
271275
# Allow Coordinator to edit any user, including their roles.
272276
db.security.addPermissionToRole('Coordinator', 'Edit', 'user')
273277
db.security.addPermissionToRole('Coordinator', 'Web Roles')
@@ -303,8 +307,12 @@ def edit_query(db, userid, itemid):
303307
return userid == db.query.get(itemid, 'creator')
304308
p = db.security.addPermission(name='View', klass='query', check=view_query,
305309
description="User is allowed to view their own and public queries")
310+
s = db.security.addPermission(name='Search', klass='query',
311+
properties=['creator'],
312+
description="User is allowed to Search queries for creator")
306313
for r in 'User', 'Developer', 'Coordinator':
307314
db.security.addPermissionToRole(r, p)
315+
db.security.addPermissionToRole(r, s)
308316
p = db.security.addPermission(name='Edit', klass='query', check=edit_query,
309317
description="User is allowed to edit their queries")
310318
for r in 'User', 'Developer', 'Coordinator':
@@ -313,6 +321,14 @@ def edit_query(db, userid, itemid):
313321
description="User is allowed to create queries")
314322
for r in 'User', 'Developer', 'Coordinator':
315323
db.security.addPermissionToRole(r, p)
324+
p = db.security.addPermission(name='Retire', klass='query', check=edit_query,
325+
description="User is allowed to retire their queries")
326+
for r in 'User', 'Developer', 'Coordinator':
327+
db.security.addPermissionToRole(r, p)
328+
p = db.security.addPermission(name='Restore', klass='query', check=edit_query,
329+
description="User is allowed to restore their queries")
330+
for r in 'User', 'Developer', 'Coordinator':
331+
db.security.addPermissionToRole(r, p)
316332

317333

318334
#

0 commit comments

Comments
 (0)