Python 3 preparation: avoid string.join().

Author: jsm28

frontends/roundup.cgi

@@ -140,14 +140,14 @@ class RequestWrapper:
 # Main CGI handler
 #
 def main(out, err):
-    import os, string
+    import os
     import roundup.instance
     path = os.environ.get('PATH_INFO', '/').split('/')
     request = RequestWrapper(out)
     request.path = os.environ.get('PATH_INFO', '/')
     tracker = path[1]
     os.environ['TRACKER_NAME'] = tracker
-    os.environ['PATH_INFO'] = string.join(path[2:], '/')
+    os.environ['PATH_INFO'] = '/'.join(path[2:])
     if tracker in TRACKER_HOMES:
         # redirect if we need a trailing '/'
         if len(path) == 2:

roundup/cgi/apache.py

@@ -123,7 +123,7 @@ def handler(req):
     _env = dict(req.subprocess_env)
     # XXX classname must be the first item in PATH_INFO.  roundup.cgi does:
     #       path = os.environ.get('PATH_INFO', '/').split('/')
-    #       os.environ['PATH_INFO'] = string.join(path[2:], '/')
+    #       os.environ['PATH_INFO'] = '/'.join(path[2:])
     #   we just remove the first character ('/')
     _env["PATH_INFO"] = req.path_info[1:]
     if _timing:

roundup/cgi/cgitb.py

@@ -7,7 +7,7 @@
 from __future__ import print_function
 __docformat__ = 'restructuredtext'
 
-import sys, os, string, keyword, linecache, tokenize, inspect, cgi
+import sys, os, keyword, linecache, tokenize, inspect, cgi
 import pydoc, traceback
 
 from roundup.cgi import templating, TranslationService
@@ -180,7 +180,7 @@ def linereader(file=file, lnum=[lnum]):
                 name = '<em>global</em> <strong>%s</strong>' % name
             lvals.append('%s&nbsp;= %s'%(name, value))
         if lvals:
-            lvals = string.join(lvals, ', ')
+            lvals = ', '.join(lvals)
             lvals = indent + '<small><font color="#909090">%s'\
                 '</font></small><br>'%lvals
         else:
@@ -200,7 +200,7 @@ def linereader(file=file, lnum=[lnum]):
             if i == lnum:
                 excerpt.append(lvals)
             i = i + 1
-        traceback.append('<p>' + level + string.join(excerpt, '\n'))
+        traceback.append('<p>' + level + '\n'.join(excerpt))
 
     traceback.reverse()
 
@@ -210,7 +210,7 @@ def linereader(file=file, lnum=[lnum]):
         value = pydoc.html.repr(getattr(evalue, name))
         attribs.append('<br>%s%s&nbsp;= %s' % (indent, name, value))
 
-    return head + string.join(attribs) + string.join(traceback) + '<p>&nbsp;</p>'
+    return head + ' '.join(attribs) + ' '.join(traceback) + '<p>&nbsp;</p>'
 
 def handler():
     print(breaker())