Python 3 preparation: avoid string.split().

Author: jsm28

frontends/roundup.cgi

@@ -86,7 +86,7 @@ except:
 # Check environment for config items
 #
 def checkconfig():
-    import os, string
+    import os
     global TRACKER_HOMES, LOG
 
     # see if there's an environment var. ROUNDUP_INSTANCE_HOMES is the
@@ -97,9 +97,9 @@ def checkconfig():
         homes = os.environ.get('TRACKER_HOMES', '')
     if homes:
         TRACKER_HOMES = {}
-        for home in string.split(homes, os.pathsep):
+        for home in homes.split(os.pathsep):
             try:
-                name, dir = string.split(home, '=', 1)
+                name, dir = home.split('=', 1)
             except ValueError:
                 # ignore invalid definitions
                 continue
@@ -142,7 +142,7 @@ class RequestWrapper:
 def main(out, err):
     import os, string
     import roundup.instance
-    path = string.split(os.environ.get('PATH_INFO', '/'), '/')
+    path = os.environ.get('PATH_INFO', '/').split('/')
     request = RequestWrapper(out)
     request.path = os.environ.get('PATH_INFO', '/')
     tracker = path[1]

roundup/cgi/apache.py

@@ -122,7 +122,7 @@ def handler(req):
     req.add_common_vars()
     _env = dict(req.subprocess_env)
     # XXX classname must be the first item in PATH_INFO.  roundup.cgi does:
-    #       path = string.split(os.environ.get('PATH_INFO', '/'), '/')
+    #       path = os.environ.get('PATH_INFO', '/').split('/')
     #       os.environ['PATH_INFO'] = string.join(path[2:], '/')
     #   we just remove the first character ('/')
     _env["PATH_INFO"] = req.path_info[1:]

roundup/cgi/cgitb.py

@@ -112,7 +112,7 @@ def html(context=5, i18n=None):
     etype, evalue = sys.exc_info()[0], sys.exc_info()[1]
     if type(etype) is type:
         etype = etype.__name__
-    pyver = 'Python ' + string.split(sys.version)[0] + '<br>' + sys.executable
+    pyver = 'Python ' + sys.version.split()[0] + '<br>' + sys.executable
     head = pydoc.html.heading(
         _('<font size=+1><strong>%(exc_type)s</strong>: %(exc_value)s</font>')
         % {'exc_type': etype, 'exc_value': evalue},

roundup/mailgw.py

@@ -95,7 +95,7 @@ class node. Any parts of other types are each stored in separate files
 from __future__ import print_function
 __docformat__ = 'restructuredtext'
 
-import string, re, os, mimetools, smtplib, socket, binascii, quopri
+import re, os, mimetools, smtplib, socket, binascii, quopri
 import time, random, sys, logging
 import codecs
 import traceback
@@ -1555,7 +1555,7 @@ def handle_Message(self, message):
         except MailUsageHelp:
             # bounce the message back to the sender with the usage message
             self.logger.debug("MailUsageHelp raised, bouncing.")
-            fulldoc = '\n'.join(string.split(__doc__, '\n')[2:])
+            fulldoc = '\n'.join(__doc__.split('\n')[2:])
             m = ['']
             m.append('\n\nMail Gateway Help\n=================')
             m.append(fulldoc)
@@ -1564,7 +1564,7 @@ def handle_Message(self, message):
         except MailUsageError as value:
             # bounce the message back to the sender with the usage message
             self.logger.debug("MailUsageError raised, bouncing.")
-            fulldoc = '\n'.join(string.split(__doc__, '\n')[2:])
+            fulldoc = '\n'.join(__doc__.split('\n')[2:])
             m = ['']
             m.append(str(value))
             m.append('\n\nMail Gateway Help\n=================')
@@ -1719,7 +1719,7 @@ def setPropArrayFromString(self, cl, propString, nodeid=None):
     '''
     props = {}
     errors = []
-    for prop in string.split(propString, ';'):
+    for prop in propString.split(';'):
         # extract the property name and value
         try:
             propname, value = prop.split('=')