Prevent AttributeError when removing all roles of a user

When making the entry field empty newvalues.get('roles') is None, causing:
AttributeError: 'NoneType' object has no attribute 'split'

Author: ThomasAH

share/roundup/templates/classic/detectors/userauditor.py

@@ -66,7 +66,9 @@ def audit_user_fields(db, cl, nodeid, newvalues):
         if check_main or check_alts:
             raise ValueError, 'Email address %s already in use' % address
 
-    for rolename in [r.lower().strip() for r in newvalues.get('roles', '').split(',')]:
+    newroles = newvalues.get('roles')
+    if newroles:
+        for rolename in [r.lower().strip() for r in newroles.split(',')]:
             if rolename and not db.security.role.has_key(rolename):
                 raise ValueError, 'Role "%s" does not exist'%rolename
 

share/roundup/templates/devel/detectors/userauditor.py

@@ -66,7 +66,9 @@ def audit_user_fields(db, cl, nodeid, newvalues):
         if check_main or check_alts:
             raise ValueError, 'Email address %s already in use' % address
 
-    for rolename in [r.lower().strip() for r in newvalues.get('roles', '').split(',')]:
+    newroles = newvalues.get('roles')
+    if newroles:
+        for rolename in [r.lower().strip() for r in newroles.split(',')]:
             if rolename and not db.security.role.has_key(rolename):
                 raise ValueError, 'Role "%s" does not exist'%rolename
 

share/roundup/templates/minimal/detectors/userauditor.py

@@ -66,7 +66,9 @@ def audit_user_fields(db, cl, nodeid, newvalues):
         if check_main or check_alts:
             raise ValueError, 'Email address %s already in use' % address
 
-    for rolename in [r.lower().strip() for r in newvalues.get('roles', '').split(',')]:
+    newroles = newvalues.get('roles')
+    if newroles:
+        for rolename in [r.lower().strip() for r in newroles.split(',')]:
             if rolename and not db.security.role.has_key(rolename):
                 raise ValueError, 'Role "%s" does not exist'%rolename
 

website/issues/detectors/userauditor.py

@@ -66,7 +66,9 @@ def audit_user_fields(db, cl, nodeid, newvalues):
         if check_main or check_alts:
             raise ValueError, 'Email address %s already in use' % address
 
-    for rolename in [r.lower().strip() for r in newvalues.get('roles', '').split(',')]:
+    newroles = newvalues.get('roles')
+    if newroles:
+        for rolename in [r.lower().strip() for r in newroles.split(',')]:
             if rolename and not db.security.role.has_key(rolename):
                 raise ValueError, 'Role "%s" does not exist'%rolename