Skip to content

Commit 6414ec5

Browse files
committed
Unified all copies of detectors/userauditor.py
The only functional change for the minimal and classic template is that the error message for invalid addresses now contains the address that caused the error. For the devel and website trackers the print command probably used while debugging was removed. Everything else is comment and vim modeline.
1 parent 465939b commit 6414ec5

File tree

4 files changed

+48
-4
lines changed

4 files changed

+48
-4
lines changed

share/roundup/templates/classic/detectors/userauditor.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ def audit_user_fields(db, cl, nodeid, newvalues):
5858

5959
for address in get_addresses(newvalues):
6060
if not valid_address(address):
61-
raise ValueError, 'Email address syntax is invalid'
61+
raise ValueError, 'Email address syntax is invalid "%s"'%address
6262

6363
check_main = db.user.stringFind(address=address)
6464
# make sure none of the alts are owned by anyone other than us (x!=nodeid)

share/roundup/templates/devel/detectors/userauditor.py

Lines changed: 23 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,24 @@
1+
# Copyright (c) 2003 Richard Jones ([email protected])
2+
#
3+
# Permission is hereby granted, free of charge, to any person obtaining a copy
4+
# of this software and associated documentation files (the "Software"), to deal
5+
# in the Software without restriction, including without limitation the rights
6+
# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
7+
# copies of the Software, and to permit persons to whom the Software is
8+
# furnished to do so, subject to the following conditions:
9+
#
10+
# The above copyright notice and this permission notice shall be included in
11+
# all copies or substantial portions of the Software.
12+
#
13+
# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
14+
# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
15+
# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
16+
# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
17+
# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
18+
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
19+
# SOFTWARE.
20+
#
21+
122
import re
223

324
# regular expression thanks to: http://www.regular-expressions.info/email.html
@@ -37,7 +58,6 @@ def audit_user_fields(db, cl, nodeid, newvalues):
3758

3859
for address in get_addresses(newvalues):
3960
if not valid_address(address):
40-
print newvalues
4161
raise ValueError, 'Email address syntax is invalid "%s"'%address
4262

4363
check_main = db.user.stringFind(address=address)
@@ -69,3 +89,5 @@ def init(db):
6989
# fire before changes are made
7090
db.user.audit('set', audit_user_fields)
7191
db.user.audit('create', audit_user_fields)
92+
93+
# vim: sts=4 sw=4 et si

share/roundup/templates/minimal/detectors/userauditor.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ def audit_user_fields(db, cl, nodeid, newvalues):
5858

5959
for address in get_addresses(newvalues):
6060
if not valid_address(address):
61-
raise ValueError, 'Email address syntax is invalid'
61+
raise ValueError, 'Email address syntax is invalid "%s"'%address
6262

6363
check_main = db.user.stringFind(address=address)
6464
# make sure none of the alts are owned by anyone other than us (x!=nodeid)

website/issues/detectors/userauditor.py

Lines changed: 23 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,24 @@
1+
# Copyright (c) 2003 Richard Jones ([email protected])
2+
#
3+
# Permission is hereby granted, free of charge, to any person obtaining a copy
4+
# of this software and associated documentation files (the "Software"), to deal
5+
# in the Software without restriction, including without limitation the rights
6+
# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
7+
# copies of the Software, and to permit persons to whom the Software is
8+
# furnished to do so, subject to the following conditions:
9+
#
10+
# The above copyright notice and this permission notice shall be included in
11+
# all copies or substantial portions of the Software.
12+
#
13+
# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
14+
# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
15+
# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
16+
# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
17+
# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
18+
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
19+
# SOFTWARE.
20+
#
21+
122
import re
223

324
# regular expression thanks to: http://www.regular-expressions.info/email.html
@@ -37,7 +58,6 @@ def audit_user_fields(db, cl, nodeid, newvalues):
3758

3859
for address in get_addresses(newvalues):
3960
if not valid_address(address):
40-
print newvalues
4161
raise ValueError, 'Email address syntax is invalid "%s"'%address
4262

4363
check_main = db.user.stringFind(address=address)
@@ -69,3 +89,5 @@ def init(db):
6989
# fire before changes are made
7090
db.user.audit('set', audit_user_fields)
7191
db.user.audit('create', audit_user_fields)
92+
93+
# vim: sts=4 sw=4 et si

0 commit comments

Comments
 (0)